fix: ensure that model name in summary is the **resolved** name without wildcards#59
Merged
Conversation
Collaborator
Author
|
/lgtm review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🦉 lgtm Review
Score: LGTM 👍
🔍 Summary
This PR successfully addresses the issue where review summaries displayed wildcard model names (e.g., "gemini-flash-*") instead of the actual resolved model name (e.g., "gemini-2.0-flash"). The changes accurately update the PublishMetadata with the resolved model_name and are thoroughly supported by updated tests. The overall quality of the code is high, and the PR is ready to be merged.
More information
- Id:
4ff4dfd53cf040aab8c4c7846c66fcaa - Model:
gemini-2.5-flash-preview-05-20 - Created at:
2025-06-23T10:43:22.772044+00:00
Usage summary
Call 1
- Request count:
1 - Request tokens:
7807 - Response tokens:
71 - Total tokens:
8695
Call 2
- Request count:
1 - Request tokens:
2880 - Response tokens:
115 - Total tokens:
4206
Total tokens: 12901
See the 📚 lgtm-ai repository for more information about lgtm.
sacha-c
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were showing stuff like "gemini-flash-*" in the summary comment, when we actually want to show the real model resolved.