chore: bump mypy from 1.19.1 to 1.20.0

dependabot[bot] · sdn4z · commit df8b0bc9830f · 2026-04-10T11:29:05.000+02:00
Bumps [mypy](https://github.com/python/mypy) from 1.19.1 to 1.20.0. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.19.1...v1.20.0) --- updated-dependencies: - dependency-name: mypy dependency-version: 1.20.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
diff --git a/.github/workflows/auto-merge.yml b/.github/workflows/auto-merge.yml
@@ -12,7 +12,7 @@ jobs:
     steps:
       - name: Dependabot metadata
         id: metadata
-        uses: dependabot/fetch-metadata@ffa630c65fa7e0ecfa0625b5ceda64399aea1b36 # v3.0.0
+        uses: dependabot/fetch-metadata@21025c705c08248db411dc16f3619e6b5f9ea21a # v2.5.0
         with:
           github-token: "${{ secrets.GITHUB_TOKEN }}"
       - name: Enable auto-merge for Dependabot PRs
diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml
@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
       - name: Install uv
-        uses: astral-sh/setup-uv@cec208311dfd045dd5311c1add060b2062131d57 # v8.0.0
+        uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
 
       - name: Build the package
         run: uv build --python $PYTHON_VERSION
diff --git a/.github/workflows/bump-version.yml b/.github/workflows/bump-version.yml
@@ -12,7 +12,7 @@ jobs:
 
     name: "Bump version and create changelog with commitizen"
     steps:
-      - uses: actions/create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859 # v3.0.0
+      - uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2.2.1
         id: app-token
         with:
           app-id: ${{ vars.ELEMENTSINTERACTIVE_BOT_APP_ID }}
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
       - name: Install uv
-        uses: astral-sh/setup-uv@cec208311dfd045dd5311c1add060b2062131d57 # v8.0.0
+        uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
 
       - name: Install the project
         run: uv sync --locked --group lint --group test --all-extras --python 3.13
diff --git a/.github/workflows/preview-bump-version.yml b/.github/workflows/preview-bump-version.yml
@@ -12,7 +12,7 @@ jobs:
 
     name: "Preview next version"
     steps:
-      - uses: actions/create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859 # v3.0.0
+      - uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2.2.1
         id: app-token
         with:
           app-id: ${{ vars.ELEMENTSINTERACTIVE_BOT_APP_ID }}
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -21,7 +21,7 @@ jobs:
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       - name: Install uv
-        uses: astral-sh/setup-uv@cec208311dfd045dd5311c1add060b2062131d57 # v8.0.0
+        uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
       - name: Publish to pypi
         run: |
           uv build --python 3.13
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
       - name: Install uv
-        uses: astral-sh/setup-uv@cec208311dfd045dd5311c1add060b2062131d57 # v8.0.0
+        uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
 
       - name: Install the project
         run: uv sync --locked --group test --all-extras --python 3.13
diff --git a/eval/evaluator.py b/eval/evaluator.py
@@ -25,7 +25,7 @@ async def evaluate(
 ) -> None:
     agent_class = get_agent_class_from_agent_name(agent)
     classified_articles = await Classifier(
-        agent=agent_class(prompt, model=model),
+        agent=agent_class(len(sources) > 1 if sources else False, prompt, model=model),
         score=score_threshold,
         relevant_articles=relevant_articles,
         non_relevant_articles=non_relevant_articles,
diff --git a/src/lightman_ai/ai/base/agent.py b/src/lightman_ai/ai/base/agent.py
@@ -16,6 +16,7 @@ class BaseAgent(ABC):
 
     def __init__(
         self,
+        multiple_sources: bool,
         system_prompt: str,
         model: str | None = None,
         logger: logging.Logger | None = None,
@@ -26,7 +27,7 @@ def __init__(
             model=agent_model,
             output_type=SelectedArticlesList,
             system_prompt=system_prompt,
-            instructions=MERGE_ARTICLES_FROM_DIFFERENT_SOURCES,
+            instructions=MERGE_ARTICLES_FROM_DIFFERENT_SOURCES if multiple_sources else None,
         )
         self.logger = logger or logging.getLogger("lightman")
         self.logger.info("Selected %s's %s model", self, selected_model)
diff --git a/src/lightman_ai/main.py b/src/lightman_ai/main.py
@@ -77,15 +77,13 @@ async def lightman(
     if not sources:
         raise NoSourcesError
 
-    tasks = [_get_articles_from_source(source, start_date) for source in sources]
-    articles_lists = await asyncio.gather(*tasks)
-
     articles = ArticlesList()
-    for articles_list in articles_lists:
-        articles += articles_list
+    for source in sources:
+        articles += await _get_articles_from_source(source, start_date)
 
+    multiple_sources = len(sources) > 1
     agent_class = get_agent_class_from_agent_name(agent)
-    agent_instance = agent_class(prompt, model, logger=logger)
+    agent_instance = agent_class(multiple_sources, prompt, model, logger=logger)
 
     classified_articles = await _classify_articles(
         articles=articles,
diff --git a/src/lightman_ai/sources/bleeping_computer.py b/src/lightman_ai/sources/bleeping_computer.py
@@ -8,12 +8,7 @@
 from httpx import AsyncClient
 from lightman_ai.article.models import Article, ArticlesList
 from lightman_ai.sources.base import BaseSource
-from lightman_ai.sources.exceptions import (
-    IncompleteArticleFromSourceError,
-    MalformedSourceResponseError,
-    NoArticlesError,
-    SourceError,
-)
+from lightman_ai.sources.exceptions import IncompleteArticleFromSourceError, MalformedSourceResponseError
 from pydantic import ValidationError
 
 logger = logging.getLogger("lightman")
@@ -29,19 +24,14 @@ class BleepingComputerSource(BaseSource):
     @override
     async def get_articles(self, date: datetime | None = None) -> ArticlesList:
         """Return the articles that are present in BleepingComputer feed."""
-        try:
-            logger.info("Downloading articles from %s", BLEEPING_COMPUTER_URL)
-            feed = await self.get_feed()
-            articles = self._xml_to_list_of_articles(feed)
-            logger.info("Articles properly downloaded and parsed.")
-            if not articles:
-                raise NoArticlesError
-            if date:
-                return ArticlesList.get_articles_from_date_onwards(articles=articles, start_date=date)
-            else:
-                return ArticlesList(articles=articles)
-        except Exception as e:
-            raise SourceError("Could not download articles from BleepingComputer") from e
+        logger.info("Downloading articles from %s", BLEEPING_COMPUTER_URL)
+        feed = await self.get_feed()
+        articles = self._xml_to_list_of_articles(feed)
+        logger.info("Articles properly downloaded and parsed.")
+        if date:
+            return ArticlesList.get_articles_from_date_onwards(articles=articles, start_date=date)
+        else:
+            return ArticlesList(articles=articles)
 
     async def get_feed(self) -> str:
         """Retrieve the BleepingComputer RSS Feed."""
diff --git a/src/lightman_ai/sources/exceptions.py b/src/lightman_ai/sources/exceptions.py
@@ -8,11 +8,3 @@ class MalformedSourceResponseError(BaseSourceError):
 
 class IncompleteArticleFromSourceError(MalformedSourceResponseError):
     """Exception for when all the mandatory fields could not be retrieved from an article."""
-
-
-class SourceError(BaseSourceError):
-    """Exception for when something went wrong while downloading or parsing the articles from source."""
-
-
-class NoArticlesError(BaseSourceError):
-    """Exception for when no articles where found after the download was successful."""
diff --git a/src/lightman_ai/sources/the_hacker_news.py b/src/lightman_ai/sources/the_hacker_news.py
@@ -8,7 +8,7 @@
 from httpx import AsyncClient
 from lightman_ai.article.models import Article, ArticlesList
 from lightman_ai.sources.base import BaseSource
-from lightman_ai.sources.exceptions import MalformedSourceResponseError, NoArticlesError, SourceError
+from lightman_ai.sources.exceptions import MalformedSourceResponseError
 from pydantic import ValidationError
 
 logger = logging.getLogger("lightman")
@@ -25,19 +25,14 @@ class TheHackerNewsSource(BaseSource):
     @override
     async def get_articles(self, date: datetime | None = None) -> ArticlesList:
         """Return the articles that are present in THN feed."""
-        try:
-            logger.info("Downloading articles from %s", THN_URL)
-            feed = await self.get_feed()
-            articles = self._xml_to_list_of_articles(feed)
-            if not articles:
-                raise NoArticlesError
-            logger.info("Articles properly downloaded and parsed.")
-            if date:
-                return ArticlesList.get_articles_from_date_onwards(articles=articles, start_date=date)
-            else:
-                return ArticlesList(articles=articles)
-        except Exception as e:
-            raise SourceError("Could not download articles from THN source") from e
+        logger.info("Downloading articles from %s", THN_URL)
+        feed = await self.get_feed()
+        articles = self._xml_to_list_of_articles(feed)
+        logger.info("Articles properly downloaded and parsed.")
+        if date:
+            return ArticlesList.get_articles_from_date_onwards(articles=articles, start_date=date)
+        else:
+            return ArticlesList(articles=articles)
 
     async def get_feed(self) -> str:
         """Retrieve the TheHackerNews' RSS Feed."""
diff --git a/tests/ai/base/test_agent.py b/tests/ai/base/test_agent.py
@@ -19,7 +19,7 @@ class TestBaseAgent:
     @patch("lightman_ai.ai.base.agent.Agent")
     async def test__get_prompt_result(self, m_agent: Mock, test_prompt: str, thn_news: ArticlesList) -> None:
         """Check that we receive an instance of `SelectedArticlesList` when running the method."""
-        agent = FakeAgent(test_prompt)
+        agent = FakeAgent(False, test_prompt)
 
         with patch("tests.ai.base.test_agent.FakeAgent.run_prompt") as m_run_prompt:
             await agent.run_prompt(str(thn_news))
@@ -32,7 +32,7 @@ async def test__get_prompt_result(self, m_agent: Mock, test_prompt: str, thn_new
 
     @patch("lightman_ai.ai.base.agent.Agent")
     async def test_agent_is_intantiated_with_model_when_set(self, m_agent: Mock, test_prompt: str) -> None:
-        agent = FakeAgent(test_prompt, model="my model")
+        agent = FakeAgent(False, test_prompt, model="my model")
         await agent.run_prompt("")
 
         assert m_agent.call_count == 1
diff --git a/tests/ai/gemini/test_agent.py b/tests/ai/gemini/test_agent.py
@@ -8,7 +8,7 @@
 
 
 class TestGeminiAgent:
-    agent = GeminiAgent(system_prompt="Test system prompt")
+    agent = GeminiAgent(False, system_prompt="Test system prompt")
 
     async def test__run_prompt(self, test_prompt: str) -> None:
         """Test that we can run a prompt and receive a SelectedArticlesList."""
diff --git a/tests/ai/openai/test_agent.py b/tests/ai/openai/test_agent.py
@@ -5,7 +5,7 @@
 
 
 class TestAgent:
-    agent = OpenAIAgent(system_prompt="Test system prompt")
+    agent = OpenAIAgent(False, system_prompt="Test system prompt")
 
     async def test__run_prompt(self, test_prompt: str) -> None:
         """Test that we can run a prompt and receive a SelectedArticlesList."""
diff --git a/tests/sources/test_bleeping_computer.py b/tests/sources/test_bleeping_computer.py
@@ -1,10 +1,9 @@
 from datetime import UTC, datetime
-from unittest.mock import patch
 
 import pytest
 from lightman_ai.article.models import ArticlesList
 from lightman_ai.sources.bleeping_computer import BleepingComputerSource
-from lightman_ai.sources.exceptions import MalformedSourceResponseError, SourceError
+from lightman_ai.sources.exceptions import MalformedSourceResponseError
 from tests.conftest import patch_httpx_client_get
 
 
@@ -101,13 +100,3 @@ def test_xml_to_list_of_articles_validation_error(self) -> None:
         </rss>"""  # no title
 
         assert not BleepingComputerSource()._xml_to_list_of_articles(xml)
-
-    async def test_get_articles_raises_when_no_articles_in_feed(self, bc_xml: str) -> None:
-        with (
-            patch_httpx_client_get(bc_xml),
-            patch(
-                "lightman_ai.sources.bleeping_computer.BleepingComputerSource._xml_to_list_of_articles", return_value=[]
-            ),
-            pytest.raises(SourceError),
-        ):
-            await BleepingComputerSource().get_articles()
diff --git a/tests/sources/test_the_hacker_news.py b/tests/sources/test_the_hacker_news.py
@@ -1,9 +1,8 @@
 from datetime import UTC, datetime
-from unittest.mock import patch
 
 import pytest
 from lightman_ai.article.models import ArticlesList
-from lightman_ai.sources.exceptions import MalformedSourceResponseError, SourceError
+from lightman_ai.sources.exceptions import MalformedSourceResponseError
 from lightman_ai.sources.the_hacker_news import TheHackerNewsSource
 from tests.conftest import patch_httpx_client_get
 
@@ -127,11 +126,3 @@ def test_xml_to_list_of_articles_cleans_description(self) -> None:
 
         assert len(articles) == 1
         assert articles[0].description == "Test description with spaces"
-
-    async def test_get_articles_raises_when_no_articles_in_feed(self, thn_xml: str) -> None:
-        with (
-            patch_httpx_client_get(thn_xml),
-            patch("lightman_ai.sources.the_hacker_news.TheHackerNewsSource._xml_to_list_of_articles", return_value=[]),
-            pytest.raises(SourceError),
-        ):
-            await TheHackerNewsSource().get_articles()
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -1,6 +1,6 @@
 import json
 from datetime import datetime
-from unittest.mock import AsyncMock, Mock, call, patch
+from unittest.mock import Mock, call, patch
 from zoneinfo import ZoneInfo
 
 import pytest
@@ -9,7 +9,6 @@
 from lightman_ai import cli
 from lightman_ai.article.models import PrimarySelectedArticle
 from lightman_ai.core.config import FileConfig, PromptConfig
-from lightman_ai.sources.utils import SOURCE_CHOICES
 from tests.conftest import patch_config_file
 
 
@@ -409,38 +408,3 @@ def test_regular_output_with_no_articles(
 
         assert result.exit_code == 0
         assert "No relevant articles found." in result.output
-
-    @patch("lightman_ai.cli.load_dotenv")
-    @patch("lightman_ai.cli.FileConfig.get_config_from_file")
-    @patch("lightman_ai.cli.PromptConfig.get_config_from_file")
-    def test_exit_code_is_not_zero_if_a_source_fails(self, m_prompt: Mock, m_config: Mock, m_load_dotenv: Mock) -> None:
-        """Test that exit code is 0 when all sources fail and no articles are found.
-
-        Proves that:
-        - Sources attempted to retrieve news (httpx was called for each source)
-        - The AI agent was never invoked (no point classifying zero articles)
-        """
-        runner = CliRunner()
-        m_prompt.return_value = PromptConfig({"eval": "eval prompt"})
-        m_config.return_value = FileConfig()
-
-        with (
-            patch("httpx.AsyncClient.get") as mock_get,
-            patch("pydantic_ai.Agent.run", new_callable=AsyncMock) as mock_agent_run,
-            patch_config_file(),
-        ):
-            mock_get.side_effect = Exception("Network error")
-            result = runner.invoke(
-                cli.run,
-                [
-                    "--agent",
-                    "openai",
-                    "--prompt",
-                    "eval",
-                    "--dry-run",
-                ],
-            )
-
-        assert result.exit_code != 0
-        assert mock_get.call_count == len(SOURCE_CHOICES)
-        assert mock_agent_run.call_count == 0
diff --git a/tests/test_main.py b/tests/test_main.py
@@ -12,7 +12,6 @@
 from lightman_ai.core.sentry import configure_sentry
 from lightman_ai.exceptions import NoSourcesError
 from lightman_ai.main import _create_service_desk_issues, _get_articles_from_source, lightman
-from lightman_ai.sources.exceptions import SourceError
 from lightman_ai.sources.utils import SOURCE_CHOICES
 from tests.conftest import patch_httpx_client_get, patch_multiple_responses
 from tests.utils import patch_agent, patch_get_articles_from_xml
@@ -117,7 +116,7 @@ async def test_lightman_and_service_desk_publish(self, test_prompt: str, thn_xml
         assert relevant_article_1.title in called_titles
         assert relevant_article_2.title in called_titles
 
-    async def test_lightman_no_publish_if_dry_run(self, test_prompt: str, thn_xml: str, bc_xml: str) -> None:
+    async def test_lightman_no_publish_if_dry_run(self, test_prompt: str, thn_xml: str) -> None:
         now = datetime.now(UTC)
         relevant_article_1 = PrimarySelectedArticle(
             title="article 2", link="https://article2.com", why_is_relevant="a", relevance_score=8, published_at=now
@@ -130,7 +129,7 @@ async def test_lightman_no_publish_if_dry_run(self, test_prompt: str, thn_xml: s
         )
         agent_response = SelectedArticlesList(articles=[relevant_article_1, relevant_article_2, not_relevant_article])
         with (
-            patch_multiple_responses([thn_xml, bc_xml]),
+            patch_httpx_client_get(thn_xml),
             patch_agent(agent_response),
             patch("lightman_ai.main.ServiceDeskIntegration.from_env") as mock_service_desk_env,
         ):
@@ -163,29 +162,6 @@ async def test_lightman_raises_error_when_sources_is_none(self) -> None:
                 dry_run=True,
             )
 
-    async def test_lightman_fails_when_one_source_raises_exception(self, test_prompt: str, thn_xml: str) -> None:
-        """Test that execution fails when one source raises an exception during download."""
-        with (
-            patch("httpx.AsyncClient.get") as mock_get,
-            patch("pydantic_ai.Agent.run", new_callable=AsyncMock) as mock_agent_run,
-        ):
-            mock_get.side_effect = [
-                Mock(text=thn_xml, **{"raise_for_status.return_value": None}),
-                Exception("Network error: Connection timeout"),
-            ]
-
-            with pytest.raises(SourceError):
-                await lightman(
-                    agent="openai",
-                    prompt=test_prompt,
-                    sources=SOURCE_CHOICES,
-                    score_threshold=8,
-                    dry_run=True,
-                )
-
-        assert mock_get.call_count == len(SOURCE_CHOICES)
-        mock_agent_run.assert_not_called()
-
 
 class TestCreateServiceDeskIssues:
     """Tests for the _create_service_desk_issues function."""
diff --git a/uv.lock b/uv.lock
