ci: require to test python package and docker build before publishing

Author: sdn4z

.github/actions/docker-build/action.yml

@@ -44,6 +44,11 @@ inputs:
     required: false
     default: "false"
 
+outputs:
+  image-tag:
+    description: "Tag of the built image"
+    value: ${{ steps.meta.outputs.tags }}
+
 runs:
   using: "composite"
   steps:
@@ -71,7 +76,7 @@ runs:
           type=semver,enable=true,pattern={{major}},prefix=v
           type=ref,event=pr,prefix=pr-,enable=true
           type=ref,event=branch,branch=main,pattern={{raw}}
-          type=ref,event=branch,branch=main,pattern={{major}},prefix=v
+          type=ref,event=branch,branch=main,pattern={{major}}
 
     - name: Build Docker image
       uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6.18.0

.github/workflows/build-test-docker.yml

@@ -3,8 +3,7 @@ name: Build and Test Docker Image
 on:
   pull_request:
     branches: ["main"]
-  push:
-    branches: ["main"]
+  workflow_call:
 
 jobs:
   should-test-docker-build:

.github/workflows/build-test-python.yml

@@ -5,16 +5,37 @@ name: Build and Test Python Package
 on:
   pull_request:
     branches: ["main"]
-  push:
-    branches: ["main"]
+  workflow_call:
 
 env:
   PYTHON_VERSION: "3.10"
 
 jobs:
+  build-package:
+    name: Build Package
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out the repo
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+
+      - name: Build package
+        uses: ./.github/actions/python-package-build
+        id: build
+        with:
+          uv-version: "0.8.22"
+          python-version: "$PYTHON_VERSION"
+
+      - name: Upload package artifact
+        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
+        with:
+          name: python-package-${{ github.sha }}
+          path: dist/
+          retention-days: 1
+
   test-build-package-extras:
     name: Test package build ${{ matrix.name}}
     runs-on: ubuntu-latest
+    needs: build-package
     permissions:
       contents: read
     strategy:
@@ -32,35 +53,43 @@ jobs:
       - name: Check out the repo
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
-      - name: Build package
-        uses: ./.github/actions/python-package-build
-        id: build
+      - name: Download package artifact
+        uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
         with:
-          uv-version: "0.8.22"
-          python-version: "$PYTHON_VERSION"
+          name: python-package-${{ github.sha }}
+          path: dist/
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@5a095e7a2014a4212f075830d4f7277575a9d098 # v7.3.1
+
       - name: Test package
         run: |
           uv venv --python $PYTHON_VERSION
-          uv pip install "${{ steps.build.outputs.wheel-file }}[${{ matrix.name }}]"
+          WHEEL_FILE=$(ls dist/*.whl)
+          uv pip install "$WHEEL_FILE[${{ matrix.name }}]"
           uv run ${{ matrix.test-args }}
 
-  test-build-package:
+  test-build-package-no-extras:
     name: Test package build no extras
     runs-on: ubuntu-latest
+    needs: build-package
     permissions:
       contents: read
     steps:
       - name: Check out the repo
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
-      - name: Build package
-        uses: ./.github/actions/python-package-build
-        id: build
+      - name: Download package artifact
+        uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
         with:
-          uv-version: "0.8.22"
-          python-version: "$PYTHON_VERSION"
+          name: python-package-${{ github.sha }}
+          path: dist/
+      - name: Install uv
+        uses: astral-sh/setup-uv@5a095e7a2014a4212f075830d4f7277575a9d098 # v7.3.1
+
       - name: Test package
         run: |
           uv venv --python $PYTHON_VERSION
-          uv pip install "${{ steps.build.outputs.wheel-file }}"
+          WHEEL_FILE=$(ls dist/*.whl)
+          uv pip install "$WHEEL_FILE"
           uv run python -c 'import twyn; twyn.check_dependencies()'

.github/workflows/publish.yml

@@ -5,24 +5,33 @@ on:
     tags:
       - "v*.*.*"
 
+env:
+  PYTHON_VERSION: "3.10"
+
 jobs:
+  build_and_test_package:
+    uses: ./.github/workflows/build-test-python.yml
+
+  build_and_test_docker:
+    uses: ./.github/workflows/build-test-docker.yml
+
   publish_to_pypi:
     name: Publish to PyPI
     runs-on: ubuntu-latest
-
+    needs: [build_and_test_package, build_and_test_docker]
     permissions:
       id-token: write
-      contents: read
-
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
-      - name: Build package
-        uses: ./.github/actions/python-package-build
-        id: build
+      - name: Download package artifacts
+        uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
         with:
-          uv-version: "0.8.22"
-          python-version: "3.10"
+          name: python-package-${{ github.sha }}
+          path: dist
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@eac588ad8def6316056a12d4907a9d4d84ff7a3b # v7.3.0
 
       - name: Publish package
         run: |
@@ -31,6 +40,7 @@ jobs:
   publish_to_dockerhub:
     name: Push Docker images to registries
     runs-on: ubuntu-latest
+    needs: [build_and_test_docker, build_and_test_package]
     permissions:
       contents: read
       packages: write

debug_regex.py

@@ -0,0 +1,4 @@
+import re
+namespace_pattern = re.compile(r"^(?:[a-z0-9]+(?:[._-][a-z0-9]+)*\/)[a-z0-9]+(?:[._-][a-z0-9]+)*$")
+package = "internal-registry.company.com/backend-team/alpine"
+print(namespace_pattern.match(package.lower()))