feat!: check_dependencies returns the list of dependencies#252
Merged
sdn4z merged 1 commit intoelementsinteractive:mainfrom Aug 20, 2025
Merged
feat!: check_dependencies returns the list of dependencies#252sdn4z merged 1 commit intoelementsinteractive:mainfrom
sdn4z merged 1 commit intoelementsinteractive:mainfrom
Conversation
Collaborator
|
Why is this a breaking change? The executable |
Collaborator
Author
I thought on making it breaking because of that actually! I guess we have to decide where to draw the line here. Imo, since we support different Python versions we implicitly acknowledge that it is indeed meant to be used as a library. |
sdn4z
force-pushed
the
check-deps
branch
10 times, most recently
from
14cf462 to
23d3c50
Compare
scastlara
approved these changes
Aug 20, 2025
sdn4z
added a commit
that referenced
this pull request
Aug 20, 2025
BREAKING CHANGE: check_dependencies now returns the list of dependencies
sdn4z
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up until this PR, check_dependencies was returning a bool, making reference to if there were errors found or not. Now, it returns a list of the errors found instead.
Some other breaking addition where made at the same time, like changing the name of the argument
dependencies_clitodependencies.BREAKING CHANGE: check_dependencies returns the list of dependencies and function arguments' names have changed