You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm removing the custom logging level handler that we had from the early days, in favor of a more simplistic approach where the user can simply modify twyn's logger as any other logger.
This PR introduces the following behaviours:
When running as a cli tool, the logging level is set as specified in the cli
When running as a 3rd party library, all logging is disabled by default. The user can set the logging level as they wish before using twyn by configuring the "twyn logger".
Gotcha. Since we are above 1.0.0, we should be careful with these breaking changes, and maybe merge them a bit and release them at once? There's been a few lately.
Gotcha. Since we are above 1.0.0, we should be careful with these breaking changes, and maybe merge them a bit and release them at once? There's been a few lately.
Totally agree!
I'm putting together for 4.0.0's release everything that's related to "twyn as a library", to avoid a quazillion major bumps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm removing the custom logging level handler that we had from the early days, in favor of a more simplistic approach where the user can simply modify
twyn's logger as any other logger.This PR introduces the following behaviours:
closes #303
BREAKING CHANGE