Skip to content

refactor: remove custom logging implementation#302

Merged
sdn4z merged 1 commit into
elementsinteractive:mainfrom
sdn4z:verbosity-level
Sep 3, 2025
Merged

refactor: remove custom logging implementation#302
sdn4z merged 1 commit into
elementsinteractive:mainfrom
sdn4z:verbosity-level

Conversation

@sdn4z
Copy link
Copy Markdown
Collaborator

@sdn4z sdn4z commented Sep 3, 2025

I'm removing the custom logging level handler that we had from the early days, in favor of a more simplistic approach where the user can simply modify twyn's logger as any other logger.

This PR introduces the following behaviours:

  • When running as a cli tool, the logging level is set as specified in the cli
  • When running as a 3rd party library, all logging is disabled by default. The user can set the logging level as they wish before using twyn by configuring the "twyn logger".

closes #303
BREAKING CHANGE

@scastlara
Copy link
Copy Markdown
Collaborator

Why is it breaking?

@sdn4z
Copy link
Copy Markdown
Collaborator Author

sdn4z commented Sep 3, 2025

Why is it breaking?

the library interface (check_dependencies()) signature has changed, the verbosity argument is no longer there! Plus, I've renamed use_track in favor of show_progress_bar.
https://github.com/elementsinteractive/twyn/pull/302/files#diff-814dedefc2eb7e589119510f15db759d203e36192b41cbb5751ffad17253fcaaL32

@scastlara
Copy link
Copy Markdown
Collaborator

Why is it breaking?

the library interface (check_dependencies()) signature has changed, the verbosity argument is no longer there! Plus, I've renamed use_track in favor of show_progress_bar. https://github.com/elementsinteractive/twyn/pull/302/files#diff-814dedefc2eb7e589119510f15db759d203e36192b41cbb5751ffad17253fcaaL32

Gotcha. Since we are above 1.0.0, we should be careful with these breaking changes, and maybe merge them a bit and release them at once? There's been a few lately.

@sdn4z
Copy link
Copy Markdown
Collaborator Author

sdn4z commented Sep 3, 2025

Why is it breaking?

the library interface (check_dependencies()) signature has changed, the verbosity argument is no longer there! Plus, I've renamed use_track in favor of show_progress_bar. https://github.com/elementsinteractive/twyn/pull/302/files#diff-814dedefc2eb7e589119510f15db759d203e36192b41cbb5751ffad17253fcaaL32

Gotcha. Since we are above 1.0.0, we should be careful with these breaking changes, and maybe merge them a bit and release them at once? There's been a few lately.

Totally agree!
I'm putting together for 4.0.0's release everything that's related to "twyn as a library", to avoid a quazillion major bumps.

@sdn4z sdn4z merged commit 0f76196 into elementsinteractive:main Sep 3, 2025
12 checks passed
@sdn4z sdn4z deleted the verbosity-level branch September 3, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove custom logging level implementation

2 participants