feat: use repo as source of truth#317
Conversation
fb2a465 to
8e5a5d3
Compare
8e5a5d3 to
ba80b5c
Compare
| Replaces call with the output you would get from downloading the top Npm packages list. | ||
| """ | ||
| json_response = {"packages": [{"name": name} for name in packages]} | ||
| json_response = {"packages": packages, "date": datetime.datetime.now().isoformat} |
There was a problem hiding this comment.
| json_response = {"packages": packages, "date": datetime.datetime.now().isoformat} | |
| json_response = {"packages": packages, "date": datetime.datetime.now().isoformat()} |
ba80b5c to
b521495
Compare
scastlara
left a comment
There was a problem hiding this comment.
We need to update the README, specifically this section where it says PyPI reference: https://github.com/elementsinteractive/twyn?tab=readme-ov-file#configuration-file
b521495 to
60d54c4
Compare
|
And this is a breaking change, since we are changing the format input of one of the parameters of twyn. |
60d54c4 to
8230f4f
Compare
I was still going through the PR, I didn't make it a draft because I thought I was going to finish before you'd jump into it (wrong assumption). It is breaking indeed, I'll add it to the PR description. All the changes related to the dependencies vendoring will be released on 4.0.0, so it was safe on that side, since it won't break any old implementations. |
BREAKING CHANGE
8230f4f to
5fdd657
Compare
With this PR we start downloading the packages from our repo.
It contains some small refactoring in the
TopXXReferencesclasses.closes #313
BREAKING CHANGE