Skip to content

feat: use repo as source of truth#317

Merged
sdn4z merged 2 commits into
elementsinteractive:mainfrom
sdn4z:update-source
Sep 10, 2025
Merged

feat: use repo as source of truth#317
sdn4z merged 2 commits into
elementsinteractive:mainfrom
sdn4z:update-source

Conversation

@sdn4z
Copy link
Copy Markdown
Collaborator

@sdn4z sdn4z commented Sep 10, 2025

With this PR we start downloading the packages from our repo.

It contains some small refactoring in the TopXXReferences classes.

closes #313

BREAKING CHANGE

Comment thread src/twyn/trusted_packages/references/base.py Outdated
Comment thread tests/conftest.py Outdated
Replaces call with the output you would get from downloading the top Npm packages list.
"""
json_response = {"packages": [{"name": name} for name in packages]}
json_response = {"packages": packages, "date": datetime.datetime.now().isoformat}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
json_response = {"packages": packages, "date": datetime.datetime.now().isoformat}
json_response = {"packages": packages, "date": datetime.datetime.now().isoformat()}

Copy link
Copy Markdown
Collaborator

@scastlara scastlara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the README, specifically this section where it says PyPI reference: https://github.com/elementsinteractive/twyn?tab=readme-ov-file#configuration-file

@scastlara
Copy link
Copy Markdown
Collaborator

And this is a breaking change, since we are changing the format input of one of the parameters of twyn.

@sdn4z
Copy link
Copy Markdown
Collaborator Author

sdn4z commented Sep 10, 2025

And this is a breaking change, since we are changing the format input of one of the parameters of twyn.

I was still going through the PR, I didn't make it a draft because I thought I was going to finish before you'd jump into it (wrong assumption).

It is breaking indeed, I'll add it to the PR description.

All the changes related to the dependencies vendoring will be released on 4.0.0, so it was safe on that side, since it won't break any old implementations.

@github-actions github-actions Bot added feature and removed feature labels Sep 10, 2025
@sdn4z sdn4z merged commit 7b639ec into elementsinteractive:main Sep 10, 2025
12 checks passed
@sdn4z sdn4z deleted the update-source branch September 10, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vendor dependencies in out repo

2 participants