feat: support multiple dependency files in config and cli#335
Merged
sdn4z merged 1 commit intoSep 17, 2025
Merged
Conversation
sdn4z
force-pushed
the
multiple-dependency-files-cli
branch
from
2d0d3cf to
8a0443c
Compare
Collaborator
Author
|
/lgtm review |
sdn4z
force-pushed
the
multiple-dependency-files-cli
branch
from
8a0443c to
a1b9a13
Compare
sdn4z
force-pushed
the
multiple-dependency-files-cli
branch
from
a1b9a13 to
1548e6e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🦉 lgtm Review
Score: Nitpicks 🤓
🔍 Summary
This PR introduces a valuable feature by allowing multiple dependency files to be specified. The implementation is solid and covers changes in the CLI, configuration, and core logic. Tests have been updated and new ones added to ensure correctness.
I've noted a few areas for improvement:
- Renaming a parameter for consistency and clarity.
- Bringing back a user-facing log message that was removed, which is especially useful when processing multiple files.
- A minor performance optimization in the dependency selector.
These are minor points, and overall the PR is in good shape. Please address the comments before merging.
More information
- Id:
fdac09348e3f455a9433309b27aa90ca - Model:
gemini-2.5-pro - Created at:
2025-09-17T09:36:08.300965+00:00
Usage summary
- Request count:
2 - Request tokens:
64,853 - Response tokens:
20,188 - Total tokens:
85,041
See the 📚 lgtm-ai repository for more information about lgtm.
sdn4z
force-pushed
the
multiple-dependency-files-cli
branch
from
1548e6e to
8bb09b0
Compare
scastlara
reviewed
Sep 17, 2025
scastlara
reviewed
Sep 17, 2025
sdn4z
force-pushed
the
multiple-dependency-files-cli
branch
from
8bb09b0 to
01ebfc6
Compare
scastlara
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRs allows the user to set multiple files both via the cli and the config file.
In a future PR we will validate the types of the config fields.
refs #325