Conversation
|
/lgtm review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🦉 lgtm Review
Score: Needs Work 🔧
🔍 Summary
This PR does a great job of refactoring the CI pipelines by separating the Python package and Docker image workflows. The new structure is much clearer and the approach of testing before publishing is a significant improvement.
The main issue is a critical one in the Docker image testing for pull requests, which will fail because it tries to use a Docker tag that isn't being generated. I've also added a couple of minor suggestions to improve code reuse in the Python package build action by using outputs from previous steps.
After addressing the Docker tagging issue, this PR will be in excellent shape and ready for merge.
More information
- Id:
e6ce92ce8a52499787f82764241e71ad - Model:
gemini-2.5-pro - Created at:
2025-10-01T14:33:37.615945+00:00
Usage summary
- Request count:
2 - Request tokens:
61,586 - Response tokens:
18,347 - Total tokens:
79,933
See the 📚 lgtm-ai repository for more information about lgtm.
2 participants
Here I've refactored the logic in the ci so that we have actions for both building python packages and docker images.
I've also removed the part where we were testing both of them after the merge. Instead, this checks will run only once, before we're deploying, to ensure that only if both the python package and the docker image are correct we are publishing.
I've split in 2 different files the logic for building and testing in PRs, one file is for the python package only and the other one is for the docker image. The reason is, since they no longer run automatically after merging, if we want to test the docker image before publishing we can do so manually now. Even if it does not make much sense to manually run the build&test of the python package, just for the sake of unifying both flows I've also added this functionality in that workflow.