Skip to content

ci: require to test python package and docker build before publishing#423

Merged
sdn4z merged 1 commit intoelementsinteractive:mainfrom
sdn4z:fix-docker-build
Mar 6, 2026
Merged

ci: require to test python package and docker build before publishing#423
sdn4z merged 1 commit intoelementsinteractive:mainfrom
sdn4z:fix-docker-build

Conversation

@sdn4z
Copy link
Copy Markdown
Collaborator

@sdn4z sdn4z commented Mar 6, 2026

No description provided.

@github-actions github-actions bot added the CI label Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from cc1e877 to 20f2b18 Compare March 6, 2026 12:05
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from 20f2b18 to d2ef6bc Compare March 6, 2026 12:07
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from d2ef6bc to 3e489c6 Compare March 6, 2026 12:08
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from 3e489c6 to a1c451a Compare March 6, 2026 12:09
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch 2 times, most recently from ba6635c to ae02a3d Compare March 6, 2026 12:10
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from ae02a3d to a7a72da Compare March 6, 2026 12:17
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from a7a72da to 613d80a Compare March 6, 2026 12:25
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from 613d80a to b6d27bc Compare March 6, 2026 12:30
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from b6d27bc to 635353c Compare March 6, 2026 14:11
@github-actions github-actions bot removed the CI label Mar 6, 2026
@github-actions github-actions bot added the CI label Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from 635353c to a8a36ef Compare March 6, 2026 14:26
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from a8a36ef to 71c64a2 Compare March 6, 2026 14:29
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from 71c64a2 to 1881c19 Compare March 6, 2026 14:40
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from 1881c19 to 4608ee9 Compare March 6, 2026 14:46
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from 4608ee9 to 71735ad Compare March 6, 2026 14:46
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z force-pushed the fix-docker-build branch from 71735ad to 7461f35 Compare March 6, 2026 14:48
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z
Copy link
Copy Markdown
Collaborator Author

sdn4z commented Mar 6, 2026

/lgtm review

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦉 lgtm Review

Score: Needs Work 🔧

🔍 Summary

This PR is a great step forward in making our CI workflows more modular and robust by introducing reusable workflows and ensuring tests are run before publishing. The overall structure is much improved.

There are a couple of configuration issues that will cause the CI to fail. Specifically, it seems an invalid uv version is being used, and the default image-tag for the Docker build workflow is invalid. I've also added a couple of minor suggestions for improving clarity and consistency.

Once these points are addressed, this will be an excellent contribution. Great work on the refactoring!

More information
  • Id: 694eb6f42194407086073bfa050ad503
  • Model: gemini-2.5-pro
  • Created at: 2026-03-06T14:53:12.275719+00:00
Usage summary
  • Request count: 2
  • Request tokens: 31,534
  • Response tokens: 16,671
  • Total tokens: 48,205
Configuration
  • model: gemini-2.5-pro

  • model_url: None

  • technologies: ('Python',)

  • categories: ('Correctness', 'Quality', 'Testing', 'Security')

  • exclude: ('*.md', 'uv.lock', 'eval/classified_articles.py')

  • additional_context: ()

  • publish: True

  • output_format: pretty

  • silent: False

  • ai_retries: None

  • ai_input_tokens_limit: 500000

  • issues_url: None

  • issues_regex: (?:refs?|closes?|resolves?)[:\s]*((?:#\d+)|(?:#?[A-Z]+-\d+))|(?:fix|feat|docs|style|refactor|perf|test|build|ci)\((?:#(\d+)|#?([A-Z]+-\d+))\)!?:

  • issues_platform: None

  • compare: HEAD

See the 📚 lgtm-ai repository for more information about lgtm.

@sdn4z sdn4z force-pushed the fix-docker-build branch from 7461f35 to a88967c Compare March 6, 2026 15:07
@github-actions github-actions bot added CI and removed CI labels Mar 6, 2026
@sdn4z sdn4z marked this pull request as ready for review March 6, 2026 15:10
@sdn4z sdn4z requested a review from scastlara as a code owner March 6, 2026 15:10
@sdn4z sdn4z merged commit f6f4272 into elementsinteractive:main Mar 6, 2026
17 checks passed
@sdn4z sdn4z deleted the fix-docker-build branch March 6, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants