Skip to content

Fix missing raise keyword in _get_selector_method #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaelMVS wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing raise keyword in _get_selector_method #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/twyn/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ def _get_dependencies_list(
def _get_selector_method(selector_method: str) -> SelectorMethod:
"""Return the selector_method from set of available ones."""
if selector_method not in SELECTOR_METHOD_MAPPING:
InvalidSelectorMethodError("Invalid selector method")
raise InvalidSelectorMethodError("Invalid selector method")
Comment on lines 281 to +282
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The raised error message is quite generic. For parity with the config validation (e.g., listing allowed selector methods), consider including the invalid value and the valid options (from SELECTOR_METHOD_MAPPING.keys()) to make CLI/config failures easier to diagnose.

Copilot uses AI. Check for mistakes.

Comment on lines 279 to 283
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type annotation appears incorrect: SelectorMethod (from twyn.base.constants) is a Literal[...] of method names, but this function returns an instantiated selector (SELECTOR_METHOD_MAPPING[selector_method]()), not the string key. Consider updating the return type (and related parameter annotations where this value is passed around) to the appropriate selector base type/protocol to avoid misleading typing.

Copilot uses AI. Check for mistakes.
return SELECTOR_METHOD_MAPPING[selector_method]()

Expand Down
Loading