fix: address review comments

Signed-off-by: melodicore <datafox@datafox.me>

Author: melodicore

elide-plugin/src/main/kotlin/dev/elide/maven/plugin/ElideCompileMojoImpl.kt

@@ -12,7 +12,6 @@
  */
 package dev.elide.maven.plugin
 
-import dev.elide.maven.compiler.ElideJavacCompiler
 import org.apache.maven.plugin.compiler.AbstractCompilerMojo
 import org.apache.maven.plugin.compiler.CompilerMojo
 import org.apache.maven.plugins.annotations.Parameter
@@ -27,11 +26,17 @@ open class ElideCompileMojoImpl : CompilerMojo() {
     /** Elide executable location. */
     @Parameter(name = "executable") var executable: String? = null
 
-    init {
+    override fun execute() {
         AbstractCompilerMojo::class.java.getDeclaredField("compilerId").apply {
             isAccessible = true
             set(this@ElideCompileMojoImpl, "elide")
         }
-        ElideJavacCompiler.executable = executable
+        executable?.let {
+            AbstractCompilerMojo::class.java.getDeclaredField("executable").apply {
+                isAccessible = true
+                set(this@ElideCompileMojoImpl, it)
+            }
+        }
+        super.execute()
     }
 }

elide-plugin/src/main/kotlin/dev/elide/maven/plugin/ElideTestCompileMojoImpl.kt

@@ -12,7 +12,6 @@
  */
 package dev.elide.maven.plugin
 
-import dev.elide.maven.compiler.ElideJavacCompiler
 import org.apache.maven.plugin.compiler.AbstractCompilerMojo
 import org.apache.maven.plugin.compiler.TestCompilerMojo
 import org.apache.maven.plugins.annotations.Parameter
@@ -27,11 +26,17 @@ open class ElideTestCompileMojoImpl : TestCompilerMojo() {
     /** Elide executable location. */
     @Parameter(name = "executable") var executable: String? = null
 
-    init {
+    override fun execute() {
         AbstractCompilerMojo::class.java.getDeclaredField("compilerId").apply {
             isAccessible = true
             set(this@ElideTestCompileMojoImpl, "elide")
         }
-        ElideJavacCompiler.executable = executable
+        executable?.let {
+            AbstractCompilerMojo::class.java.getDeclaredField("executable").apply {
+                isAccessible = true
+                set(this@ElideTestCompileMojoImpl, it)
+            }
+        }
+        super.execute()
     }
 }

java-compiler/src/main/kotlin/dev/elide/maven/compiler/ElideJavacCompiler.kt

@@ -78,7 +78,7 @@ open class ElideJavacCompiler :
     }
 
     private fun getElideExecutable(config: CompilerConfiguration): String =
-        executable ?: config.executable ?: ElideLocator.locate()?.absolutePathString() ?: ELIDE_EXECUTABLE
+        config.executable ?: ElideLocator.locate()?.absolutePathString() ?: ELIDE_EXECUTABLE
 
     override fun createCommandLine(config: CompilerConfiguration): Array<String> {
         return buildElideArgs(config, getSourceFiles(config)).toTypedArray()
@@ -207,9 +207,4 @@ open class ElideJavacCompiler :
         val kind = if (exitCode == 0) CompilerMessage.Kind.NOTE else CompilerMessage.Kind.ERROR
         return input.map { CompilerMessage(it, kind) }
     }
-
-    companion object {
-        // allow overriding executable in elide-maven-plugin
-        var executable: String? = null
-    }
 }

java-compiler/src/main/kotlin/dev/elide/maven/compiler/ElideLocator.kt

@@ -12,6 +12,7 @@
  */
 package dev.elide.maven.compiler
 
+import java.io.File.pathSeparatorChar
 import java.nio.file.Path
 import java.nio.file.Paths
 
@@ -36,7 +37,7 @@ object ElideLocator {
      */
     fun locate(): Path? {
         val path = System.getenv("PATH") ?: ""
-        for (pathCandidate in path.split(':')) {
+        for (pathCandidate in path.split(pathSeparatorChar)) {
             val candidate = Paths.get(pathCandidate, ELIDE_EXECUTABLE)
             if (isValidElideBinary(candidate)) {
                 return candidate