Skip to content

feat: UX Overhaul#8

Merged
Lauri "datafox" Heino (melodicore) merged 19 commits into
mainfrom
feat/ux-overhaul
May 11, 2026
Merged

feat: UX Overhaul#8
Lauri "datafox" Heino (melodicore) merged 19 commits into
mainfrom
feat/ux-overhaul

Conversation

@melodicore
Copy link
Copy Markdown
Member

  • Use <extensions> in Elide Kotlin Maven plugin
  • Create new Elide Maven Plugin
    • While the Kotlin plugin is a drop-in replacement, this plugin is specifically for Elide
    • Configures Elide as a default Java and Kotlin compiler, no need to use any other plugins
  • Rename elide-plexus-compilers to elide-java-compiler
    • Breaking change, but we haven't released this yet so it's fine
  • Update all samples and readmes

Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 37 out of 40 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

java-compiler/src/main/kotlin/dev/elide/maven/compiler/ElideLocator.kt:41

  • PATH is split using a hard-coded ':', which will fail on Windows (where the path separator is ';') and can also behave incorrectly when path entries contain : (drive letters). Use the platform path separator (e.g. File.pathSeparatorChar / System.getProperty("path.separator")) when splitting PATH, and keep using ELIDE_EXECUTABLE for the filename.
    java-compiler/src/main/kotlin/dev/elide/maven/compiler/ElideJavacCompiler.kt:83
  • ElideJavacCompiler uses a mutable global (companion object executable) to override the binary path. Because the mojos are marked threadSafe and Maven can run compiles in parallel (multi-module / -T), this introduces a race where one module’s configured executable can affect another module’s compilation. Prefer passing the executable through CompilerConfiguration (i.e., rely on config.executable) or make the override instance-scoped instead of global mutable state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread elide-plugin/src/main/kotlin/dev/elide/maven/plugin/ElideCompileMojoImpl.kt Outdated
Comment thread elide-plugin/src/main/kotlin/dev/elide/maven/plugin/ElideTestCompileMojoImpl.kt Outdated
Comment thread sample-kotlin/pom.xml
Comment thread sample-mixed/pom.xml
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 41 out of 45 changed files in this pull request and generated 8 comments.

Comment thread elide-plugin/pom.xml
Comment thread kotlin-plugin/src/main/resources/META-INF/plexus/components.xml Outdated
Comment thread elide-plugin/src/main/resources/META-INF/plexus/components.xml Outdated
Comment thread java-compiler/src/main/kotlin/dev/elide/maven/compiler/ElideJavacCompiler.kt Outdated
Comment thread Makefile
Signed-off-by: melodicore <datafox@datafox.me>
@melodicore Lauri "datafox" Heino (melodicore) merged commit 5fda895 into main May 11, 2026
1 check passed
@melodicore Lauri "datafox" Heino (melodicore) deleted the feat/ux-overhaul branch May 11, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants