Use isoparse instead of datetime.fromisoformat (#116)

Author: jasper-elimity

src/elimity_insights_client/api/_decode_query_results_page.py

@@ -1,6 +1,8 @@
+from datetime import date, time
 from json import loads
 from typing import List
 
+from dateutil.parser import isoparse
 from typing_extensions import TypedDict
 
 from elimity_insights_client._util import map_list
@@ -18,7 +20,6 @@
     GroupByQueryResultsPage,
     GroupByQueryResult,
 )
-from datetime import date, datetime, time
 
 
 class EntityDict(TypedDict):
@@ -108,7 +109,7 @@ def _decode_value(dict: ValueDict) -> Value:
         return DateValue(date_value)
 
     if type == "dateTime":
-        date_time_value = datetime.fromisoformat(value)
+        date_time_value = isoparse(value)
         return DateTimeValue(date_time_value)
 
     if type == "number":

src/elimity_insights_client/api/_decode_source.py

@@ -1,5 +1,6 @@
 from typing import TypedDict, Optional
 
+from dateutil.parser import isoparse
 from typing_extensions import NotRequired
 
 from elimity_insights_client._decode_domain_graph_schema import (
@@ -12,7 +13,6 @@
     AbsentLastReloadTimestamp,
     PresentLastReloadTimestamp,
 )
-from datetime import datetime
 
 
 class SourceDict(TypedDict):
@@ -40,5 +40,5 @@ def decode_source(dict: SourceDict) -> Source:
 def _decode_last_reload_timestamp(value: Optional[str]) -> LastReloadTimestamp:
     if value is None:
         return AbsentLastReloadTimestamp()
-    val = datetime.fromisoformat(value)
+    val = isoparse(value)
     return PresentLastReloadTimestamp(val)

tests/elimity_insights_client/api/query-results-page.json

@@ -11,6 +11,10 @@
         {
           "type": "boolean",
           "value": "false"
+        },
+        {
+          "type": "dateTime",
+          "value": "2006-05-04T03:02:01Z"
         }
       ],
       "linkGroupByPages": [

tests/elimity_insights_client/api/test_decode_query_results_page.py

@@ -1,3 +1,4 @@
+from datetime import datetime, timezone
 from importlib.resources import open_binary
 from json import load
 from typing import List
@@ -14,13 +15,16 @@
     QueryResult,
     QueryResultsPage,
     Value,
+    DateTimeValue,
 )
 
 
 def test_decode_query_results_page() -> None:
     entity = Entity(True, "bar", "foo")
-    inclusion: Value = BooleanValue(False)
-    inclusions = [inclusion]
+    inclusion1: Value = BooleanValue(False)
+    dat = datetime(2006, 5, 4, 3, 2, 1, tzinfo=timezone.utc)
+    inclusion2: Value = DateTimeValue(dat)
+    inclusions = [inclusion1, inclusion2]
     label = NumberValue(42)
     sub_pages: List[GroupByQueryResultsPage] = []
     link_group_by_result = GroupByQueryResult(0, label, sub_pages)