Skip to content

Commit ea86bc6

Browse files
authored
Changing <All Time> label and hint (#36)
The original title “All time” and the hint “Messages since start” could be ambiguous for users trying to understand what the statistics represent. Changing the title to “Successful” and clarifying the hint helps users better understand the metrics being displayed, making the UI more user-friendly.
1 parent a5207de commit ea86bc6

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

lib/broadway_dashboard.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ defmodule BroadwayDashboard do
246246
<:col>
247247
<.row>
248248
<:col>
249-
<.card title="All time" hint="Messages since start." inner_title="successful"><%= @stats.successful %></.card>
249+
<.card title="Successful" hint="Messages since the BroadwayDashboard page was first mounted." inner_title="successful"><%= @stats.successful %></.card>
250250
</:col>
251251
<:col>
252252
<.card inner_title="failed"><%= @stats.failed %></.card>

test/broadway_dashboard_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ defmodule BroadwayDashboardTest do
8787
rendered = render(live)
8888
assert rendered =~ "Updates automatically"
8989
assert rendered =~ "Throughput"
90-
assert rendered =~ "All time"
90+
assert rendered =~ "Successful"
9191
end
9292

9393
test "auto discover is enabled when pipeline is registered using via" do
@@ -131,7 +131,7 @@ defmodule BroadwayDashboardTest do
131131
rendered = render(live)
132132
assert rendered =~ "Updates automatically"
133133
assert rendered =~ "Throughput"
134-
assert rendered =~ "All time"
134+
assert rendered =~ "Successful"
135135

136136
assert rendered =~ "prod_0"
137137

0 commit comments

Comments
 (0)