Update to work with phoenix_live_dashboard 0.8#26
Merged
Conversation
Contributor
|
Everything is perfect so far @moxley, thank you. It is fine to depend on latest dashboard, please let us know when this is ready to merge or if you have any other questions. |
Contributor
Author
|
Thanks @josevalim. I resolved the remaining issue, and this is now ready to merge. |
philss
approved these changes
Jun 28, 2023
|
@moxley thank you! 💜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating from
phoenix 1.7.3to1.7.6, we started seeing warnings appear in the output of our tests:Here are our relevant dependencies:
phoenix 1.7.6phoenix_live_dashboard 0.7.2phoenix_live_view 0.18.18broadway_dashboard 0.3.0Since
phoenix_live_view 0.18.18was apparently the culprit, I tried updating it to the latest version,0.19.3. Thenphoenix_live_dashboard 0.7.2wouldn't work with0.19.x, so I tried upgradingphoenix_live_dashboardto the latest, version0.8.0. Then,broadway_dashboardwouldn't work with that, because it only supports up to0.7.x. It uses a now-removed API withinphoenix_live_dashboard.Incidentally,
phoenix_profilerhas the samephoenix_live_dashboardAPI issue, and I opened a PR for that as well.This PR updates
broadway_dashboardto use the newphoenix_live_dashboardAPI, but does this satisfy your versioning requirements? This PR makesbroadway_dashboardrequire at leastphoenix_live_dashboard 0.8.TODO