Skip to content

Update to work with phoenix_live_dashboard 0.8#26

Merged
philss merged 4 commits into
elixir-broadway:mainfrom
moxley:update-phoenix-dashboard
Jun 28, 2023
Merged

Update to work with phoenix_live_dashboard 0.8#26
philss merged 4 commits into
elixir-broadway:mainfrom
moxley:update-phoenix-dashboard

Conversation

@moxley

@moxley moxley commented Jun 27, 2023

Copy link
Copy Markdown
Contributor

After updating from phoenix 1.7.3 to 1.7.6, we started seeing warnings appear in the output of our tests:

warning: Passing "connect_info" directly to connect/3 is deprecated, please pass "connect_info: ..." as an option instead
  (phoenix 1.7.6) lib/phoenix/test/channel_test.ex:329: Phoenix.ChannelTest.__connect__/4
  (phoenix_live_view 0.18.18) lib/phoenix_live_view/test/live_view_test.ex:1140: Phoenix.LiveViewTest.start_upload_client/6

Here are our relevant dependencies:

  • phoenix 1.7.6
  • phoenix_live_dashboard 0.7.2
  • phoenix_live_view 0.18.18
  • broadway_dashboard 0.3.0

Since phoenix_live_view 0.18.18 was apparently the culprit, I tried updating it to the latest version, 0.19.3. Then phoenix_live_dashboard 0.7.2 wouldn't work with 0.19.x, so I tried upgrading phoenix_live_dashboard to the latest, version 0.8.0. Then, broadway_dashboard wouldn't work with that, because it only supports up to 0.7.x. It uses a now-removed API within phoenix_live_dashboard.

Incidentally, phoenix_profiler has the same phoenix_live_dashboard API issue, and I opened a PR for that as well.

This PR updates broadway_dashboard to use the new phoenix_live_dashboard API, but does this satisfy your versioning requirements? This PR makes broadway_dashboard require at least phoenix_live_dashboard 0.8.

TODO

  • Fix layout bug introduced in this PR
  • Finish manually testing UI

@josevalim

Copy link
Copy Markdown
Contributor

Everything is perfect so far @moxley, thank you. It is fine to depend on latest dashboard, please let us know when this is ready to merge or if you have any other questions.

@moxley

moxley commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @josevalim. I resolved the remaining issue, and this is now ready to merge.

@philss
philss merged commit 1833f8b into elixir-broadway:main Jun 28, 2023
@philss

philss commented Jun 28, 2023

Copy link
Copy Markdown

@moxley thank you! 💜

@moxley
moxley deleted the update-phoenix-dashboard branch June 28, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants