Improve warning/error message for writable violations#4738
Merged
greg-rychlewski merged 1 commit intoJun 19, 2026
Merged
Conversation
josevalim
approved these changes
Jun 19, 2026
Member
|
thanks again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the error message introduced in #4734 to hopefully improve the user experience of actually receiving this warning / error. The updated message is patterned off of the existing message you get with
on_replace: :raisewhen trying to replace an association.The goal of the new message is twofold:
:value,:status,:archived_at, etc., it would be difficult to find out exactly which schema with said field is being violated otherwise.:writableand:on_writable_violationoptions in the message itself, it gives the user a jumping off point to reference the docs directly to figure out how to address the warning / error rather than having to try to figure out where it is coming from.Open to any other suggestions 😄