Skip to content

Fix structure_load/2 for MySQL 9.4+ #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wojtekmach merged 2 commits into from
Aug 13, 2025
Merged

Fix structure_load/2 for MySQL 9.4+ #685

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a73473
Fix structure_load/2 for MySQL 9.4+
wojtekmach Aug 13, 2025
799db88
up
wojtekmach Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions lib/ecto/adapters/myxql.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,16 +416,18 @@ defmodule Ecto.Adapters.MyXQL do
def structure_load(default, config) do
path = config[:dump_path] || Path.join(default, "structure.sql")

args = [
"--execute",
"SET FOREIGN_KEY_CHECKS = 0; SOURCE #{path}; SET FOREIGN_KEY_CHECKS = 1",
"--database",
config[:database]
]

case run_with_cmd("mysql", config, args) do
{_output, 0} -> {:ok, path}
{output, _} -> {:error, output}
with {:ok, contents} <- File.read(path) do

@josevalim josevalim Aug 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will downstream be able to handle {:error, atom()}?

@wojtekmach wojtekmach Aug 13, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, yes it handles it:

$ mix ecto.load
** (Mix) The structure for Dummy.Repo couldn't be loaded: :enoent

however previously it was a slightly better error message:

** (Mix) The structure for Dummy.Repo couldn't be loaded: ERROR at line 1: Failed to open file '/Users/wojtek/dummy/priv/repo/structure.sql', error: 2

I will do something like:

      {:error, reason} ->
        {:error, "could not read #{inspect(path)}: #{:file.format_error(reason)}"}

so that we have:

** (Mix) The structure for Dummy.Repo couldn't be loaded: could not read "/Users/wojtek/dummy/priv/repo/structure.sql": no such file or directory

args = [
"--execute",
"SET FOREIGN_KEY_CHECKS = 0; " <> contents <> "; SET FOREIGN_KEY_CHECKS = 1",
"--database",
config[:database]
]

case run_with_cmd("mysql", config, args) do
{_output, 0} -> {:ok, path}
{output, _} -> {:error, output}
end
end
end

Expand Down
Loading