Add dialyzer, and to CI

Author: kipcole9

.dialyzer_ignore_warnings

@@ -0,0 +1,2 @@
+[
+]

.github/workflows/ci.yml

@@ -85,6 +85,19 @@ jobs:
       - name: Run tests
         run: mix test
 
+      - name: Cache Dialyzer PLT
+        if: ${{ matrix.lint }}
+        uses: actions/cache@v5
+        with:
+          path: priv/plts
+          key: ${{ runner.os }}-plt-${{ matrix.otp }}-${{ matrix.elixir }}-${{ hashFiles('**/mix.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-plt-${{ matrix.otp }}-${{ matrix.elixir }}-
+
+      - name: Run Dialyzer
+        run: mix dialyzer --format github
+        if: ${{ matrix.lint }}
+
       - name: Build hex package (verify release readiness)
         run: MIX_ENV=prod mix hex.build
         if: ${{ matrix.lint }}

.gitignore

@@ -62,3 +62,6 @@ CLAUDE.md
 .claude
 
 image_lens_correction-*.tar
+
+# Dialyzer PLTs
+/priv/plts/

lensfun/lensfun.ex

@@ -14,6 +14,7 @@ defmodule Image.LensFun do
   @db_save_file "priv/lensfun/lensfun.etf"
 
   @doc "Absolute path to the bundled lensfun ETF database."
+  @doc subject: "Database", since: "0.1.0"
   def db_path do
     Application.app_dir(@app_name, @db_save_file)
   end
@@ -22,6 +23,7 @@ defmodule Image.LensFun do
   Load and decode the bundled lensfun database. Cached in the persistent
   term cache so repeated calls are cheap.
   """
+  @doc subject: "Database", since: "0.1.0"
   def db do
     case :persistent_term.get({__MODULE__, :db}, :missing) do
       :missing ->
@@ -63,6 +65,7 @@ defmodule Image.LensFun do
   * `{:error, :not_found}`.
 
   """
+  @doc subject: "Database", since: "0.1.0"
   def find_lens(maker, lens_model, options \\ []) do
     crop_factor = Keyword.get(options, :crop_factor)
 
@@ -167,6 +170,7 @@ defmodule Image.LensFun do
 
   Returns `{:ok, %{model:, mount:, crop_factor:}}` or `{:error, :not_found}`.
   """
+  @doc subject: "Database", since: "0.1.0"
   def find_camera(maker, model) do
     list = Map.get(db().cameras, canonical_maker(maker), [])
 
@@ -186,6 +190,7 @@ defmodule Image.LensFun do
   endpoints handled by clamping. Returns `{:ok, distortion}` or
   `{:error, :no_calibration}`.
   """
+  @doc subject: "Database", since: "0.1.0"
   def interpolate_distortion(%{distortion: []}, _focal), do: {:error, :no_calibration}
 
   def interpolate_distortion(%{distortion: distortions}, focal) when is_number(focal) do
@@ -206,6 +211,7 @@ defmodule Image.LensFun do
 
   Returns `{:ok, tca}` or `{:error, :no_calibration}`.
   """
+  @doc subject: "Database", since: "0.1.0"
   def interpolate_tca(lens, focal)
 
   def interpolate_tca(%{tca: []}, _focal), do: {:error, :no_calibration}
@@ -226,6 +232,7 @@ defmodule Image.LensFun do
   aperture and distance using inverse-distance weighting (the same
   approach as lensfun's `InterpolateVignetting`).
   """
+  @doc subject: "Database", since: "0.1.0"
   def interpolate_vignetting(%{vignetting: []}, _focal, _aperture, _distance) do
     {:error, :no_calibration}
   end
@@ -309,6 +316,7 @@ defmodule Image.LensFun do
   map with keys `:make`, `:model`, `:lens_make`, `:lens_model`,
   `:focal_length`, `:aperture`, `:distance`, `:crop_factor`.
   """
+  @doc subject: "Database", since: "0.1.0"
   def metrics_from_exif_and_options(%Vimage{} = image, options \\ []) do
     exif =
       case Image.exif(image) do

mix.exs

@@ -17,7 +17,13 @@ defmodule ImageLensCorrection.MixProject do
       source_url: @source_url,
       build_embedded: Mix.env() == :prod,
       start_permanent: Mix.env() == :prod,
-      elixirc_paths: elixirc_paths(Mix.env())
+      elixirc_paths: elixirc_paths(Mix.env()),
+      dialyzer: [
+        ignore_warnings: ".dialyzer_ignore_warnings",
+        plt_add_apps: ~w(mix ex_unit)a,
+        plt_local_path: "priv/plts",
+        plt_core_path: "priv/plts"
+      ]
     ]
   end
 
@@ -42,7 +48,8 @@ defmodule ImageLensCorrection.MixProject do
       # database; pulled transitively by `:image` for XMP metadata so
       # cannot be scoped to `:dev` here.
       {:sweet_xml, "~> 0.7"},
-      {:ex_doc, "~> 0.34", only: [:dev], runtime: false}
+      {:ex_doc, "~> 0.34", only: [:dev], runtime: false},
+      {:dialyxir, "~> 1.0", only: [:dev, :test], runtime: false}
     ] ++ maybe_json_polyfill()
   end
 
@@ -92,7 +99,7 @@ defmodule ImageLensCorrection.MixProject do
         "CHANGELOG.md",
         "LICENSE.md"
       ],
-      formatters: ["html"],
+      formatters: ["html", "markdown"],
       groups_for_docs: [
         Distortion: &(&1[:subject] == "Distortion"),
         Database: &(&1[:subject] == "Database")

mix.lock

@@ -1,8 +1,10 @@
 %{
   "cc_precompiler": {:hex, :cc_precompiler, "0.1.11", "8c844d0b9fb98a3edea067f94f616b3f6b29b959b6b3bf25fee94ffe34364768", [:mix], [{:elixir_make, "~> 0.7", [hex: :elixir_make, repo: "hexpm", optional: false]}], "hexpm", "3427232caf0835f94680e5bcf082408a70b48ad68a5f5c0b02a3bea9f3a075b9"},
   "color": {:hex, :color, "0.12.1", "a1c3aa9aa5ad99b3a217d49ab6743c082399af57002c83d9c8160f7f8b7a3019", [:mix], [{:bandit, "~> 1.5", [hex: :bandit, repo: "hexpm", optional: true]}, {:plug, "~> 1.15", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "b4241a97b21af453aeb72aa56e5297821003eb93ce29b2893b344bf2166a1740"},
+  "dialyxir": {:hex, :dialyxir, "1.4.7", "dda948fcee52962e4b6c5b4b16b2d8fa7d50d8645bbae8b8685c3f9ecb7f5f4d", [:mix], [{:erlex, ">= 0.2.8", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "b34527202e6eb8cee198efec110996c25c5898f43a4094df157f8d28f27d9efe"},
   "earmark_parser": {:hex, :earmark_parser, "1.4.44", "f20830dd6b5c77afe2b063777ddbbff09f9759396500cdbe7523efd58d7a339c", [:mix], [], "hexpm", "4778ac752b4701a5599215f7030989c989ffdc4f6df457c5f36938cc2d2a2750"},
   "elixir_make": {:hex, :elixir_make, "0.9.0", "6484b3cd8c0cee58f09f05ecaf1a140a8c97670671a6a0e7ab4dc326c3109726", [:mix], [], "hexpm", "db23d4fd8b757462ad02f8aa73431a426fe6671c80b200d9710caf3d1dd0ffdb"},
+  "erlex": {:hex, :erlex, "0.2.8", "cd8116f20f3c0afe376d1e8d1f0ae2452337729f68be016ea544a72f767d9c12", [:mix], [], "hexpm", "9d66ff9fedf69e49dc3fd12831e12a8a37b76f8651dd21cd45fcf5561a8a7590"},
   "ex_doc": {:hex, :ex_doc, "0.40.1", "67542e4b6dde74811cfd580e2c0149b78010fd13001fda7cfeb2b2c2ffb1344d", [:mix], [{:earmark_parser, "~> 1.4.44", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "bcef0e2d360d93ac19f01a85d58f91752d930c0a30e2681145feea6bd3516e00"},
   "image": {:hex, :image, "0.66.0", "8abf53bd01c7e988146b61a1a26e98a308c052d182ec630ce983fa6d72704f98", [:mix], [{:color, "~> 0.4", [hex: :color, repo: "hexpm", optional: false]}, {:evision, "~> 0.1.33 or ~> 0.2", [hex: :evision, repo: "hexpm", optional: true]}, {:exla, "~> 0.10", [hex: :exla, repo: "hexpm", optional: true]}, {:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: true]}, {:kino, "~> 0.13", [hex: :kino, repo: "hexpm", optional: true]}, {:nx, "~> 0.10", [hex: :nx, repo: "hexpm", optional: true]}, {:nx_image, "~> 0.1", [hex: :nx_image, repo: "hexpm", optional: true]}, {:phoenix_html, "~> 2.1 or ~> 3.2 or ~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:plug, "~> 1.13", [hex: :plug, repo: "hexpm", optional: true]}, {:req, "~> 0.4", [hex: :req, repo: "hexpm", optional: true]}, {:rustler, "> 0.0.0", [hex: :rustler, repo: "hexpm", optional: true]}, {:scholar, "~> 0.3", [hex: :scholar, repo: "hexpm", optional: true]}, {:sweet_xml, "~> 0.7", [hex: :sweet_xml, repo: "hexpm", optional: false]}, {:vix, "~> 0.33", [hex: :vix, repo: "hexpm", optional: false]}, {:xav, "~> 0.10", [hex: :xav, repo: "hexpm", optional: true]}], "hexpm", "3cd641cf715cb3fa9e03a4af09a72c8ef18a93131e74be1acc8af89306e2182f"},
   "makeup": {:hex, :makeup, "1.2.1", "e90ac1c65589ef354378def3ba19d401e739ee7ee06fb47f94c687016e3713d1", [:mix], [{:nimble_parsec, "~> 1.4", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "d36484867b0bae0fea568d10131197a4c2e47056a6fbe84922bf6ba71c8d17ce"},

test/lensfun_correct_test.exs

@@ -57,5 +57,52 @@ defmodule Image.LensFun.Correct.Test do
 
       assert diff < 0.5
     end
+
+    test ":projection routes through Geometry for a fisheye lens" do
+      # Samyang 7.5mm fisheye is in the bundled DB with type: :fisheye.
+      image = Image.new!(200, 200, color: :red, bands: 3)
+
+      assert {:ok, corrected} =
+               Correct.correct(image,
+                 lens_make: "Samyang",
+                 lens_model: "Samyang 7.5mm f/3.5 UMC Fish-eye MFT",
+                 focal_length: 7.5,
+                 aperture: 4.0,
+                 crop_factor: 2.0,
+                 corrections: [:projection],
+                 target_projection: :rectilinear
+               )
+
+      # Projection conversion preserves dimensions but should change pixel
+      # values (the image is geometrically reprojected). Compare against
+      # the input — if projection actually ran, the corner moves.
+      assert Image.width(corrected) == Image.width(image)
+      assert Image.height(corrected) == Image.height(image)
+    end
+
+    test ":projection is a no-op when source equals target" do
+      # Most lenses default to :rectilinear; selecting :rectilinear as the
+      # target is a no-op even when projection is enabled.
+      image = Image.new!(100, 100, color: [128, 64, 200], bands: 3)
+
+      assert {:ok, corrected} =
+               Correct.correct(image,
+                 lens_make: "Canon",
+                 lens_model: "Canon EF 100mm f/2.8 Macro USM",
+                 focal_length: 100.0,
+                 aperture: 5.6,
+                 crop_factor: 1.0,
+                 corrections: [:projection],
+                 target_projection: :rectilinear
+               )
+
+      diff =
+        image
+        |> Image.Math.subtract!(corrected)
+        |> Image.Math.pow!(2)
+        |> Vix.Vips.Operation.avg!()
+
+      assert diff < 0.5
+    end
   end
 end