@@ -78,6 +78,7 @@ introduced behavior, especially for bug fixes and major changes:
7878 * fails* before your change and * passes* afterward. This makes it easier to
7979 confirm that the fix addresses the underlying issue and helps prevent
8080 regressions in the future.
81+
8182 * ** New Features or Major Changes:** If you are adding a new feature or making
8283 major changes to existing functionality, please add tests that cover the
8384 major parts of that functionality. Aim to have the best code coverage possible.
@@ -88,7 +89,9 @@ We have saved some excellent pull requests we have received in the past in
8889case you are looking for some examples:
8990
9091 * [Implement Enum.member? - Pull request](https://github.com/elixir-lang/elixir/pull/992)
92+
9193 * [Add String.valid? - Pull request](https://github.com/elixir-lang/elixir/pull/1058)
94+
9295 * [Implement capture_io for ExUnit - Pull request](https://github.com/elixir-lang/elixir/pull/1059)
9396
9497# # Reviewing changes
@@ -122,27 +125,31 @@ guidelines on licensing and compliance. Below is a summary of the key points
122125affecting ** all external contributors** :
123126
124127 * Accepted Licenses: Any code contributed must be licensed under the
125- ` Apache-2.0` license.
128+ ` Apache-2.0` license.
129+
126130 * SPDX License Headers: With the exception of approved test fixture files,
127- all new or modified files in a pull request must include correct SPDX
128- headers. If you are creating a new file under the ` Apache-2.0` license, for
129- instance, please use:
131+ all new or modified files in a pull request must include correct SPDX
132+ headers. If you are creating a new file under the ` Apache-2.0` license, for
133+ instance, please use:
130134
131135 ` ` ` elixir
132136 # SPDX-License-Identifier: Apache-2.0
133137 # SPDX-FileCopyrightText: 2021 The Elixir Team
134138 ` ` `
135139
136140 * No Executable Binaries: Contributions must ** not** include any executable
137- binary files. If you require an exception (for example, certain test artifacts),
138- please see the policy on how to request approval and document exceptions.
141+ binary files. If you require an exception (for example, certain test artifacts),
142+ please see the policy on how to request approval and document exceptions.
143+
139144 * Preserving Copyright and License Info: If you copy code from elsewhere,
140- ensure that ** all original copyright and license notices remain intact** . If
141- they are missing or incomplete, you must add them.
145+ ensure that ** all original copyright and license notices remain intact** . If
146+ they are missing or incomplete, you must add them.
147+
142148 * Failure to Comply: Pull requests that do not meet these licensing and
143- compliance standards will be rejected or require modifications before merging.
149+ compliance standards will be rejected or require modifications before merging.
150+
144151 * Developer Certificate of Origin: All contributions are subject to the
145- Developer Certificate of Origin.
152+ Developer Certificate of Origin.
146153
147154 ` ` ` text
148155 By making a contribution to this project, I certify that:
0 commit comments