More fixes

Author: josevalim

lib/elixir/lib/module/types.ex

@@ -72,8 +72,10 @@ defmodule Module.Types do
 
     stack = stack(:infer, file, module, {:__info__, 1}, env, cache, handler)
 
+    # In case there are loops, the other we traverse matters,
+    # so we sort the definitions for determinism
     {types, private, %{local_sigs: reachable_sigs} = context} =
-      for {fun_arity, kind, meta, _clauses} = def <- defs,
+      for {fun_arity, kind, meta, _clauses} = def <- Enum.sort(defs),
           reduce: {[], [], context()} do
         {types, private, context} when kind in [:def, :defmacro] ->
           # Optimized version of finder, since we already have the definition

lib/elixir/lib/module/types/apply.ex

@@ -1144,7 +1144,7 @@ defmodule Module.Types.Apply do
   end
 
   defp filter_domain([{args, return} | clauses], expected, acc, all_compatible?) do
-    case compatible?(return, expected) do
+    case compatible?(expected, return) do
       true -> filter_domain(clauses, expected, [args | acc], all_compatible?)
       false -> filter_domain(clauses, expected, acc, false)
     end

lib/elixir/test/elixir/module/types/pattern_test.exs

@@ -419,6 +419,14 @@ defmodule Module.Types.PatternTest do
              """
     end
 
+    test "is_binary/1" do
+      assert typecheck!([x], is_binary(x), x) == dynamic(binary())
+      assert typecheck!([x], not is_binary(x), x) == dynamic(term())
+
+      assert typecheck!([x], is_bitstring(x), x) == dynamic(binary())
+      assert typecheck!([x], not is_bitstring(x), x) == dynamic(negation(binary()))
+    end
+
     test "is_function/2" do
       assert typecheck!([x], is_function(x, 3), x) == dynamic(fun(3))
       assert typecheck!([x], not is_function(x, 3), x) == dynamic(negation(fun(3)))