Fix warnings

Author: josevalim

lib/elixir/lib/module/types/expr.ex

@@ -762,6 +762,7 @@ defmodule Module.Types.Expr do
 
               cond do
                 stack.mode != :infer and previous != none() and subtype?(clause_type, previous) ->
+                  stack = %{stack | meta: meta}
                   {previous, Pattern.badpattern_error(clause, 0, info, stack, context)}
 
                 precise? ->

lib/elixir/lib/protocol.ex

@@ -816,6 +816,7 @@ defmodule Protocol do
         # Set up a clear slate to store defined functions
         @__functions__ []
         @fallback_to_any false
+        @undefined_impl_description ""
 
         # Invoke the user given block
         _ = unquote(block)
@@ -935,12 +936,7 @@ defmodule Protocol do
           nil
         end
 
-      # Disable Dialyzer checks - before and after consolidation
-      # the types could be more strict
-      @dialyzer {:nowarn_function, __protocol__: 1, impl_for: 1, impl_for!: 1}
-
       @doc false
-      @spec impl_for(term) :: atom | nil
       Kernel.def(impl_for(data))
 
       # Define the implementation for structs.
@@ -976,35 +972,34 @@ defmodule Protocol do
         unquote(any_impl_for)
       end
 
-      undefined_impl_description =
-        Module.get_attribute(__MODULE__, :undefined_impl_description, "")
+      # Internal handler for Structs
+      Kernel.defp struct_impl_for(struct) do
+        case Code.ensure_compiled(Protocol.__concat__(__MODULE__, struct)) do
+          {:module, module} -> module
+          {:error, _} -> unquote(any_impl_for)
+        end
+      end
 
       @doc false
-      @spec impl_for!(term) :: atom
       if any_impl_for do
         Kernel.def impl_for!(data) do
           impl_for(data)
         end
       else
         Kernel.def impl_for!(data) do
-          impl_for(data) ||
-            raise(Protocol.UndefinedError,
-              protocol: __MODULE__,
-              value: data,
-              description: unquote(undefined_impl_description)
-            )
-        end
-      end
-
-      # Internal handler for Structs
-      Kernel.defp struct_impl_for(struct) do
-        case Code.ensure_compiled(Protocol.__concat__(__MODULE__, struct)) do
-          {:module, module} -> module
-          {:error, _} -> unquote(any_impl_for)
+          unquote(
+            quote generated: true do
+              impl_for(data) ||
+                raise(Protocol.UndefinedError,
+                  protocol: __MODULE__,
+                  value: data,
+                  description: @undefined_impl_description
+                )
+            end
+          )
         end
       end
 
-      # Inline struct implementation for performance
       @compile {:inline, struct_impl_for: 1}
 
       if not Module.defines_type?(__MODULE__, {:t, 0}) do
@@ -1020,10 +1015,6 @@ defmodule Protocol do
       @__protocol__ [fallback_to_any: !!@fallback_to_any]
 
       @doc false
-      @spec __protocol__(:module) :: __MODULE__
-      @spec __protocol__(:functions) :: [{atom(), arity()}]
-      @spec __protocol__(:consolidated?) :: boolean()
-      @spec __protocol__(:impls) :: :not_consolidated | {:consolidated, [module()]}
       Kernel.def(__protocol__(:module), do: __MODULE__)
       Kernel.def(__protocol__(:functions), do: unquote(:lists.sort(@__functions__)))
       Kernel.def(__protocol__(:consolidated?), do: false)