Skip to content

Commit 82abdd2

Browse files
committed
Use error, improve docs
1 parent 2d8e146 commit 82abdd2

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

lib/mix/lib/mix/dep/converger.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ defmodule Mix.Dep.Converger do
381381
end
382382

383383
defp warn_uneeded_override(dep, parent) do
384-
Mix.shell().info(
384+
Mix.shell().error(
385385
"Dependency #{Mix.Dep.format_dep(dep)} no longer requires :override on #{inspect(parent)}"
386386
)
387387
end

lib/mix/lib/mix/tasks/deps.ex

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,11 @@ defmodule Mix.Tasks.Deps do
9999
targets (like `[:host, :rpi3]`)
100100
101101
* `:override` - if set to `true` the dependency will override any other
102-
definitions of itself by other dependencies. This option can also be a
103-
list, which overrides the definitions of only certain dependencies. If
104-
a dependency is not included in the list and an override is required,
105-
it will still fail. If a dependency is in the list and no longer necessary,
106-
then a warning is emitted
102+
definitions of itself by other dependencies. From Elixir v1.20.0,
103+
this option can also be a list of dependency names, which allows you to
104+
override the definition of specific dependencies. If a dependency is not
105+
included in the list and an override is required, it will still fail.
106+
If a dependency is in the list and no longer necessary, then an error is emitted
107107
108108
* `:manager` - Mix can also compile Rebar3 and makefile projects
109109
and can fetch sub dependencies of Rebar3 projects. Mix will

lib/mix/test/mix/dep_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1280,7 +1280,7 @@ defmodule Mix.DepTest do
12801280
end)
12811281

12821282
message = "Dependency ok 0.1.0 (deps/ok) no longer requires :override on :deps_repo"
1283-
assert_received {:mix_shell, :info, [^message]}
1283+
assert_received {:mix_shell, :error, [^message]}
12841284
end
12851285

12861286
test "warns when overrides are no longer needed" do
@@ -1298,7 +1298,7 @@ defmodule Mix.DepTest do
12981298
message =
12991299
"Dependency git_repo (#{fixture_path("git_repo")}) no longer requires :override on :deps_repo"
13001300

1301-
assert_received {:mix_shell, :info, [^message]}
1301+
assert_received {:mix_shell, :error, [^message]}
13021302
end
13031303

13041304
test "targets divergence when app is not overridden" do

0 commit comments

Comments
 (0)