More

Author: josevalim

lib/elixir/lib/module/types/descr.ex

@@ -99,6 +99,23 @@ defmodule Module.Types.Descr do
   @boolset :sets.from_list([true, false], version: 2)
   def boolean(), do: %{atom: {:union, @boolset}}
 
+  @doc """
+  Gets the upper bound of a gradual type.
+
+  This is the same as removing the gradual type.
+  """
+  def upper_bound(%{dynamic: dynamic}), do: dynamic
+  def upper_bound(static), do: static
+
+  @doc """
+  Gets the lower bound of a gradual type.
+
+  This is the same as getting the static part.
+  Note this is not generally safe and changes the representation of the type.
+  """
+  def lower_bound(:term), do: :term
+  def lower_bound(type), do: Map.delete(type, :dynamic)
+
   ## Function constructors
 
   @doc """
@@ -1120,14 +1137,6 @@ defmodule Module.Types.Descr do
     end
   end
 
-  # Gets the upper bound of a gradual type.
-  defp upper_bound(%{dynamic: dynamic}), do: dynamic
-  defp upper_bound(static), do: static
-
-  # Gets the lower bound of a gradual type.
-  defp lower_bound(:term), do: :term
-  defp lower_bound(type), do: Map.delete(type, :dynamic)
-
   @doc """
   Applies a function type to a list of argument types.
 

lib/elixir/lib/module/types/pattern.ex

@@ -41,9 +41,15 @@ defmodule Module.Types.Pattern do
 
   @doc """
   Computes the domain from the pattern tree and expected types.
+
+  Note we use `upper_bound` because the user of dynamic in the signature
+  won't make a difference.
   """
   def of_domain([{tree, expected, _pattern} | trees], context) do
-    [intersection(of_pattern_tree(tree, context), expected) | of_domain(trees, context)]
+    [
+      intersection(of_pattern_tree(tree, context), expected) |> upper_bound()
+      | of_domain(trees, context)
+    ]
   end
 
   def of_domain([], _context) do

lib/elixir/test/elixir/enum_test.exs

@@ -1192,10 +1192,6 @@ defmodule EnumTest do
     assert_raise FunctionClauseError, fn ->
       Enum.slice(list, 0, -1)
     end
-
-    assert_raise FunctionClauseError, fn ->
-      Enum.slice(list, 0.99, 0)
-    end
   end
 
   test "slice on infinite streams" do
@@ -2691,14 +2687,6 @@ defmodule EnumTest.Map do
       Enum.slice(map, 0, -1)
     end
 
-    assert_raise FunctionClauseError, fn ->
-      Enum.slice(map, 0.99, 0)
-    end
-
-    assert_raise FunctionClauseError, fn ->
-      Enum.slice(map, 0, 0.99)
-    end
-
     assert Enum.slice(map, 0, 0) == []
     assert Enum.slice(map, 0, 1) == [x1]
     assert Enum.slice(map, 0, 2) == [x1, x2]
@@ -2717,14 +2705,6 @@ defmodule EnumTest.Map do
     assert_raise FunctionClauseError, fn ->
       Enum.slice(map, 0, -1)
     end
-
-    assert_raise FunctionClauseError, fn ->
-      Enum.slice(map, 0.99, 0)
-    end
-
-    assert_raise FunctionClauseError, fn ->
-      Enum.slice(map, 0, 0.99)
-    end
   end
 
   test "reduce/3" do

lib/elixir/test/elixir/kernel/raise_test.exs

@@ -221,7 +221,7 @@ defmodule Kernel.RaiseTest do
     test "named function clause (stacktrace) or runtime (no stacktrace) error" do
       result =
         try do
-          Access.get("foo", 0)
+          Access.get(Process.get(:unused, "foo"), 0)
         rescue
           x in [FunctionClauseError, CaseClauseError] -> Exception.message(x)
         end
@@ -353,7 +353,7 @@ defmodule Kernel.RaiseTest do
     test "function clause error" do
       result =
         try do
-          Access.get(:ok, :error)
+          Access.get(Process.get(:unused, :ok), :error)
         rescue
           x in [FunctionClauseError] -> Exception.message(x)
         end

lib/elixir/test/elixir/range_test.exs

@@ -71,18 +71,6 @@ defmodule RangeTest do
     end
   end
 
-  test "limits are integer only" do
-    first = 1.0
-    last = 3.0
-    message = "ranges (first..last) expect both sides to be integers, got: 1.0..3.0"
-    assert_raise ArgumentError, message, fn -> first..last end
-
-    first = []
-    last = []
-    message = "ranges (first..last) expect both sides to be integers, got: []..[]"
-    assert_raise ArgumentError, message, fn -> first..last end
-  end
-
   test "step is a non-zero integer" do
     step = 1.0
     message = ~r"the step to be a non-zero integer"