Use Test Modules in tests instead of Elixir built-in modules#14383
Merged
Conversation
josevalim
reviewed
Apr 5, 2025
josevalim
reviewed
Apr 5, 2025
josevalim
reviewed
Apr 5, 2025
josevalim
reviewed
Apr 5, 2025
josevalim
reviewed
Apr 5, 2025
josevalim
reviewed
Apr 5, 2025
josevalim
reviewed
Apr 5, 2025
Member
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
Thank you @maennchen. Sorry I left the comments a bit everywhere but the summary is to not extract PathHelpers to a different module, let's simply defined it for the IEx suite instead, and let's make it automatically purges and deletes modules, so we don't have to explicitly call it every time.
Prep for Coverage Reporting in tests
maennchen
force-pushed
the
jm/test_modules
branch
from
f405adf to
300f0ca
Compare
josevalim
reviewed
Apr 7, 2025
| import PathHelpers | ||
|
|
||
| write_beam( | ||
| defmodule ExampleModule do |
Member
There was a problem hiding this comment.
We need to pick another name here to avoid conflicts.
josevalim
reviewed
Apr 7, 2025
josevalim
reviewed
Apr 7, 2025
josevalim
reviewed
Apr 7, 2025
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for #14343