Skip to content

Fix Integer.undigits/2 to validate negative out-of-range digits #15160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Mar 9, 2026
Merged

Fix Integer.undigits/2 to validate negative out-of-range digits #15160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/elixir/lib/integer.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,9 @@ defmodule Integer do

defp undigits([], _base, acc), do: acc

defp undigits([digit | _], base, _) when is_integer(digit) and digit >= base,
do: raise(ArgumentError, "invalid digit #{digit} in base #{base}")
defp undigits([digit | _], base, _)
when is_integer(digit) and (digit >= base or digit <= -base),
do: raise(ArgumentError, "invalid digit #{digit} in base #{base}")

defp undigits([digit | tail], base, acc) when is_integer(digit),
do: undigits(tail, base, acc * base + digit)
Expand Down
8 changes: 8 additions & 0 deletions lib/elixir/test/elixir/integer_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,14 @@ defmodule IntegerTest do
assert_raise ArgumentError, "invalid digit 17 in base 16", fn ->
Integer.undigits([1, 2, 17], 16)
end

assert_raise ArgumentError, "invalid digit -10 in base 10", fn ->
Integer.undigits([-10], 10)
end

assert_raise ArgumentError, "invalid digit -17 in base 16", fn ->
Integer.undigits([1, 2, -17], 16)
end
end

test "parse/2" do
Expand Down