Fix Integer.extended_gcd/2 returning negative GCD for zero base cases#15163
Merged
josevalim merged 1 commit intoMar 10, 2026
Merged
Conversation
When one argument is 0 and the other is negative, `extended_gcd/2` was returning a negative GCD, violating both the @SPEC (which declares `non_neg_integer`) and consistency with `gcd/2`.
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When one argument is 0 and the other is negative,
extended_gcd/2was returning a negative GCD, violating both the spec (which declaresnon_neg_integer) and consistency withgcd/2.