Unify comments

josevalim · josevalim · commit 4e95d01199e6 · 2026-06-09T16:36:03.000+02:00
diff --git a/assets/js/swup.js b/assets/js/swup.js
@@ -22,18 +22,15 @@ const maybeMetaRedirect = (visit, {page}) => {
 window.addEventListener('DOMContentLoaded', emitExdocLoaded)
 
 // Match links to local .html documentation pages, with or without a fragment.
-// Routing non-HTML files (downloads such as .mmd) through SWUP breaks the page
-// swap (#2182); the `.html#` branch keeps in-doc anchored links (function
-// references like file.html#list_dir/1, sidebar entries) on the SWUP path.
+// Note we need to explicitly check for .html so we don't use swup on other
+// formats, such as .md, and so forth.
+//
+// We want to only apply SWUP on links without "/" (or rather "/" can only
+// appear in a fragment), but it is not possible to write such selector,
+// so we check specifically for root relative links (starting with "/" or
+// starting with http) in the LINK_SELECTOR and then reject any link with
+// "/" before the fragment in "isWithinBuild".
 export const LINK_SELECTOR = 'a[href]:not([href^="/"]):not([href^="http"]):is([href$=".html"], [href*=".html#"])'
-
-// SWUP only swaps `#main`, so it must stay within a single ExDoc build: the
-// sidebar (navigation + version) is built from per-build <head> scripts SWUP
-// does not re-run. ExDoc writes every page of a build as a flat file in one
-// folder, so an in-build link is a bare filename and a slash in its path means
-// another folder/build (the Erlang/OTP docs flatten one build per application).
-// We test the path -- the part before the fragment -- not the whole href, since
-// anchors carry slashes too (the arity in file.html#list_dir/1).
 export const isWithinBuild = (href) => !href.split('#')[0].includes('/')
 
 if (!isEmbedded && window.location.protocol !== 'file:') {
