fix: address PR review comments (env parsing, range clamp, stale docs)

- config.exs: accept the same disable values ("false", "0") for
  ELIXIR_LS_TYPE_INFERENCE as the runtime override in language_server.ex, so
  dev/test and release behavior match.
- inlay_hints: clamp_range now sets a whole-line sentinel end column on the
  clamped boundary line instead of reusing the original range's final-line
  column, which could spuriously cut off hints on that line.
- markdown_utils: compute the :"..//" atom once as a module attribute
  instead of String.to_atom/1 per call.
- release_smoke_test: docstrings updated to the current git-pin state (the
  old text described the absolute path dep as a known blocker and referenced
  a companion test asserting its presence — both stale).
- bump elixir_sense pin to 43034945 (binary unit-width fix, hint cache key
  fix, doc typespec corrections).

Note: the hover heredoc-indentation comment was reviewed and declined — the
inner heredoc's closing delimiter dedents its content to column 0, so the
interpolated markdown is already flush.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvwMWQayfdxowBDrnt5iYM

Author: lukaszsamson

apps/language_server/lib/language_server/markdown_utils.ex

@@ -433,7 +433,11 @@ defmodule ElixirLS.LanguageServer.MarkdownUtils do
   # 1.20 emits it unquoted (`:..//`) while 1.16 quotes it (`:"..//"`), so no
   # single literal form is `mix format --check-formatted`-clean on both. The
   # string form is left untouched by every formatter and yields the same atom.
-  defp get_module_fun_arity("..///3"), do: {Kernel, String.to_atom("..//"), 3}
+  # Computed once at compile time (module attribute) to keep the dynamic-atom
+  # call out of the per-invocation path.
+  @stepped_range_atom String.to_atom("..//")
+
+  defp get_module_fun_arity("..///3"), do: {Kernel, @stepped_range_atom, 3}
   defp get_module_fun_arity("../2"), do: {Kernel, :.., 2}
   defp get_module_fun_arity("../0"), do: {Kernel, :.., 0}
   defp get_module_fun_arity("./2"), do: {Kernel.SpecialForms, :., 2}

apps/language_server/lib/language_server/providers/inlay_hints.ex

@@ -48,6 +48,10 @@ defmodule ElixirLS.LanguageServer.Providers.InlayHints do
   @unrecognized_trust_key_prefix {__MODULE__, :unrecognized_trust}
 
   @max_range_lines 1000
+  # Whole-line sentinel end column used when clamp_range trims a range: large
+  # enough to exceed any realistic line length, so the clamped boundary line
+  # is fully covered.
+  @max_line_column 1_000_000
   @max_hints 1000
   @default_max_label_length 60
 
@@ -821,10 +825,13 @@ defmodule ElixirLS.LanguageServer.Providers.InlayHints do
   # Clamp so at most @max_range_lines lines are ever processed: the inclusive
   # window sl..el spans `el - sl + 1` lines, so anything with `el - sl >=
   # @max_range_lines` (i.e. > @max_range_lines lines) is trimmed to the first
-  # @max_range_lines lines (sl .. sl + @max_range_lines - 1).
-  defp clamp_range({{sl, _sc} = start, {el, ec}} = range) do
+  # @max_range_lines lines (sl .. sl + @max_range_lines - 1). The new end
+  # column must be a whole-line sentinel, not the original range's `ec` — that
+  # column belongs to a different (later) line and would spuriously cut off
+  # hints on the clamped boundary line.
+  defp clamp_range({{sl, _sc} = start, {el, _ec}} = range) do
     if el - sl >= @max_range_lines do
-      {start, {sl + @max_range_lines - 1, ec}}
+      {start, {sl + @max_range_lines - 1, @max_line_column}}
     else
       range
     end

apps/language_server/test/release_smoke_test.exs

@@ -6,10 +6,10 @@ defmodule ElixirLS.LanguageServer.ReleaseSmokeTest do
 
       @moduletag :release_smoke
 
-  They are intended to run against a CLEAN checkout with production deps (no
-  `path:` overrides) before cutting a release.  Today most of them are excluded
-  because the workspace intentionally uses a local `path:` dep for
-  `elixir_sense` during development.
+  They are intended to run against a CLEAN checkout with production deps
+  before cutting a release. The `elixir_sense` dependency is a git pin
+  (`dep_versions.exs`), and the CI release-gate job plus the always-running
+  companion test below keep it that way.
 
   ## Running at release time
 
@@ -18,12 +18,10 @@ defmodule ElixirLS.LanguageServer.ReleaseSmokeTest do
   ## Tests in this module
 
   1. `no_absolute_path_deps` — asserts that no `mix.exs` file in the umbrella
-     tree contains `path: "/"` (an absolute-path dep).  Today this test
-     DOCUMENTS A KNOWN RELEASE BLOCKER: the `elixir_sense` dep in
-     `apps/language_server/mix.exs` uses an absolute `path:` pointing to a
-     local worktree.  The always-running companion test
-     (`path_dep_is_still_present`) asserts that the path dep IS present so the
-     suite notices when it is removed.
+     tree contains `path: "/"` (an absolute-path dep). The always-running
+     companion test (`companion: elixir_sense is a git pin ...`) asserts the
+     same invariant in normal CI, so a reintroduced local path dep is caught
+     immediately rather than at release time.
 
   2. `packaged_dep_compile_check` — placeholder for a manual smoke step
      (clean checkout, `mix deps.get`, hint round-trip).
@@ -102,17 +100,10 @@ defmodule ElixirLS.LanguageServer.ReleaseSmokeTest do
 
   @doc """
   Asserts that no mix.exs in the umbrella contains `path: "/"` (an absolute
-  path pointing outside the repo).
-
-  ## Known blocker (as of 2026-06-12)
-
-  `apps/language_server/mix.exs` contains:
-
-      {:elixir_sense, path: "/Users/lukaszsamson/elixir_sense/.claude/worktrees/..."}
-
-  This is a local development override.  Before cutting a release, replace it
-  with the published Hex package reference (or a GitHub ref) and verify that
-  `mix deps.get` resolves cleanly from a clean checkout.
+  path pointing outside the repo). The `elixir_sense` dep is a git pin
+  (`dep_versions.exs`); if a local `path:` override is reintroduced for
+  development, it must be swapped back before releasing — this test (and the
+  always-running companion above) will flag it.
   """
   test "no_absolute_path_deps: no mix.exs uses an absolute path dep" do
     # NOTE: This test is excluded by default (@moduletag :release_smoke).
@@ -144,8 +135,8 @@ defmodule ElixirLS.LanguageServer.ReleaseSmokeTest do
   Placeholder for the packaged-dep compile-and-hint smoke test.
 
   This test is intentionally skipped via `@tag :skip`.  It documents the
-  MANUAL STEPS that a release engineer must perform after switching from the
-  local `path:` dep to the published Hex package.
+  MANUAL STEPS that a release engineer must perform to verify the git-pinned
+  (or future Hex-published) `elixir_sense` dependency from a clean checkout.
 
   ## Manual steps
 

config/config.exs

@@ -29,9 +29,13 @@ end
 # powering inlay hints, hover, and completion). Requires Elixir 1.19+; falls
 # back to the custom engine automatically when unavailable. On by default on
 # this branch — set ELIXIR_LS_TYPE_INFERENCE=false to disable for A/B testing.
+# Keep the accepted disable values in sync with the runtime override in
+# apps/language_server/lib/language_server.ex ("false" and "0").
 config :elixir_sense,
   use_elixir_types:
-    System.get_env("ELIXIR_LS_TYPE_INFERENCE", "true") |> String.downcase() != "false"
+    System.get_env("ELIXIR_LS_TYPE_INFERENCE", "true")
+    |> String.downcase()
+    |> then(&(&1 not in ["false", "0"]))
 
 # NOTE: the native-typing backend's verbose degradation-log flood on Elixir
 # 1.18/1.19 is tamed in apps/language_server/test/test_helper.exs via per-module

dep_versions.exs

@@ -1,5 +1,5 @@
 [
-  elixir_sense: "702ff31a601ddf4f04343db7e244719852586bfe",
+  elixir_sense: "430349450cdaa2bc243bb5ba2a5948f5e9e0ea80",
   dialyxir_vendored: "accfec9393079abc4a82b7e79a4997f59f085b67",
   jason_v: "f1c10fa9c445cb9f300266122ef18671054b2330",
   erl2ex_vendored: "04f93e55f46d35d0aa3c149616f2c7a6a1ad9311",

mix.lock

@@ -2,7 +2,7 @@
   "benchee": {:hex, :benchee, "1.1.0", "f3a43817209a92a1fade36ef36b86e1052627fd8934a8b937ac9ab3a76c43062", [:mix], [{:deep_merge, "~> 1.0", [hex: :deep_merge, repo: "hexpm", optional: false]}, {:statistex, "~> 1.0", [hex: :statistex, repo: "hexpm", optional: false]}], "hexpm", "7da57d545003165a012b587077f6ba90b89210fd88074ce3c60ce239eb5e6d93"},
   "deep_merge": {:hex, :deep_merge, "1.0.0", "b4aa1a0d1acac393bdf38b2291af38cb1d4a52806cf7a4906f718e1feb5ee961", [:mix], [], "hexpm", "ce708e5f094b9cd4e8f2be4f00d2f4250c4095be93f8cd6d018c753894885430"},
   "dialyxir_vendored": {:git, "https://github.com/elixir-lsp/dialyxir.git", "accfec9393079abc4a82b7e79a4997f59f085b67", [ref: "accfec9393079abc4a82b7e79a4997f59f085b67"]},
-  "elixir_sense": {:git, "https://github.com/elixir-lsp/elixir_sense.git", "702ff31a601ddf4f04343db7e244719852586bfe", [ref: "702ff31a601ddf4f04343db7e244719852586bfe"]},
+  "elixir_sense": {:git, "https://github.com/elixir-lsp/elixir_sense.git", "430349450cdaa2bc243bb5ba2a5948f5e9e0ea80", [ref: "430349450cdaa2bc243bb5ba2a5948f5e9e0ea80"]},
   "erl2ex_vendored": {:git, "https://github.com/elixir-lsp/erl2ex.git", "04f93e55f46d35d0aa3c149616f2c7a6a1ad9311", [ref: "04f93e55f46d35d0aa3c149616f2c7a6a1ad9311"]},
   "erlex_vendored": {:git, "https://github.com/elixir-lsp/erlex.git", "50b8307f90451a5d0288fb239fb6405b5ca1f1a4", [ref: "50b8307f90451a5d0288fb239fb6405b5ca1f1a4"]},
   "jason_v": {:git, "https://github.com/elixir-lsp/jason.git", "f1c10fa9c445cb9f300266122ef18671054b2330", [ref: "f1c10fa9c445cb9f300266122ef18671054b2330"]},