ci: hard-fail release gate; pin elixir_sense 702ff31a; enforce TypeHints facade boundary

- Release gate: the absolute-path-dep check no longer has
  continue-on-error — the path dependency was replaced by a git pin, so a
  reintroduction must fail the workflow, not just show a red job. Stale
  development-phase comments updated.
- Pin elixir_sense to PR #334 head 702ff31a (Descr funnel delegates,
  property harness, short negative ExCk cache TTL, adaptor boundary test,
  TYPES_ROADMAP architecture contract).
- Add inlay_hints_boundary_test.exs: the InlayHints provider must consume
  types only through the ElixirSense.Core.TypeHints facade — direct calls to
  Binding or TypePresentation fail the test (checked against compiled BEAM
  import tables).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvwMWQayfdxowBDrnt5iYM

Author: lukaszsamson

.github/workflows/ci.yml

@@ -9,15 +9,12 @@ on:
       - master
 
 jobs:
-  # Release gate: absolute local path dependencies must never ship. This is
-  # EXPECTED to flag on the inlay-hints development branch (elixir_sense is a
-  # local worktree path dep during development) — continue-on-error keeps the
-  # branch green while documenting the blocker. Flip continue-on-error to
-  # false before release.
+  # Release gate: absolute local path dependencies must never ship. The
+  # elixir_sense dependency is a git pin (dep_versions.exs), so this job
+  # hard-fails on any reintroduction of a local path dep.
   release-gate:
     name: Reject absolute path deps (release gate)
     runs-on: ubuntu-22.04
-    continue-on-error: true
     steps:
       - uses: actions/checkout@v4
       - name: Check for absolute local path dependencies

apps/language_server/test/providers/inlay_hints_boundary_test.exs

@@ -0,0 +1,53 @@
+defmodule ElixirLS.LanguageServer.Providers.InlayHintsBoundaryTest do
+  @moduledoc """
+  Architecture boundary check: the inlay-hints provider must consume types
+  exclusively through the `ElixirSense.Core.TypeHints` facade — never through
+  `ElixirSense.Core.Binding` or `ElixirSense.Core.TypePresentation` directly.
+  Those are elixir_sense internals; the facade is the only supported LSP-facing
+  type API, so display trust levels, caching, and shape/descr translation stay
+  in one place.
+
+  Enforced against compiled BEAM import tables (actual remote-call targets),
+  so doc/comment mentions don't count.
+  """
+  use ExUnit.Case, async: true
+
+  @forbidden_prefixes [
+    "Elixir.ElixirSense.Core.Binding",
+    "Elixir.ElixirSense.Core.TypePresentation"
+  ]
+
+  test "InlayHints provider only uses the TypeHints facade for type access" do
+    provider_modules =
+      for module <- Application.spec(:language_server, :modules),
+          module
+          |> Atom.to_string()
+          |> String.starts_with?("Elixir.ElixirLS.LanguageServer.Providers.InlayHints"),
+          do: module
+
+    assert provider_modules != [], "InlayHints provider modules not found in app spec"
+
+    offenders =
+      for module <- provider_modules,
+          target <- forbidden_call_targets(module),
+          do: {module, target}
+
+    assert offenders == [],
+           "Inlay-hints provider bypasses the TypeHints facade:\n" <>
+             Enum.map_join(offenders, "\n", fn {m, {tm, tf, ta}} ->
+               "  #{inspect(m)} -> #{inspect(tm)}.#{tf}/#{ta}"
+             end)
+  end
+
+  defp forbidden_call_targets(module) do
+    with path when is_list(path) <- :code.which(module),
+         {:ok, {^module, [{:imports, imports}]}} <- :beam_lib.chunks(path, [:imports]) do
+      Enum.filter(imports, fn {target_mod, _f, _a} ->
+        target = Atom.to_string(target_mod)
+        Enum.any?(@forbidden_prefixes, &String.starts_with?(target, &1))
+      end)
+    else
+      _ -> []
+    end
+  end
+end

dep_versions.exs

@@ -1,5 +1,5 @@
 [
-  elixir_sense: "53f8879dcc496f1d19f5d3a5de721ca10b40824f",
+  elixir_sense: "702ff31a601ddf4f04343db7e244719852586bfe",
   dialyxir_vendored: "accfec9393079abc4a82b7e79a4997f59f085b67",
   jason_v: "f1c10fa9c445cb9f300266122ef18671054b2330",
   erl2ex_vendored: "04f93e55f46d35d0aa3c149616f2c7a6a1ad9311",

mix.lock

@@ -2,7 +2,7 @@
   "benchee": {:hex, :benchee, "1.1.0", "f3a43817209a92a1fade36ef36b86e1052627fd8934a8b937ac9ab3a76c43062", [:mix], [{:deep_merge, "~> 1.0", [hex: :deep_merge, repo: "hexpm", optional: false]}, {:statistex, "~> 1.0", [hex: :statistex, repo: "hexpm", optional: false]}], "hexpm", "7da57d545003165a012b587077f6ba90b89210fd88074ce3c60ce239eb5e6d93"},
   "deep_merge": {:hex, :deep_merge, "1.0.0", "b4aa1a0d1acac393bdf38b2291af38cb1d4a52806cf7a4906f718e1feb5ee961", [:mix], [], "hexpm", "ce708e5f094b9cd4e8f2be4f00d2f4250c4095be93f8cd6d018c753894885430"},
   "dialyxir_vendored": {:git, "https://github.com/elixir-lsp/dialyxir.git", "accfec9393079abc4a82b7e79a4997f59f085b67", [ref: "accfec9393079abc4a82b7e79a4997f59f085b67"]},
-  "elixir_sense": {:git, "https://github.com/elixir-lsp/elixir_sense.git", "53f8879dcc496f1d19f5d3a5de721ca10b40824f", [ref: "53f8879dcc496f1d19f5d3a5de721ca10b40824f"]},
+  "elixir_sense": {:git, "https://github.com/elixir-lsp/elixir_sense.git", "702ff31a601ddf4f04343db7e244719852586bfe", [ref: "702ff31a601ddf4f04343db7e244719852586bfe"]},
   "erl2ex_vendored": {:git, "https://github.com/elixir-lsp/erl2ex.git", "04f93e55f46d35d0aa3c149616f2c7a6a1ad9311", [ref: "04f93e55f46d35d0aa3c149616f2c7a6a1ad9311"]},
   "erlex_vendored": {:git, "https://github.com/elixir-lsp/erlex.git", "50b8307f90451a5d0288fb239fb6405b5ca1f1a4", [ref: "50b8307f90451a5d0288fb239fb6405b5ca1f1a4"]},
   "jason_v": {:git, "https://github.com/elixir-lsp/jason.git", "f1c10fa9c445cb9f300266122ef18671054b2330", [ref: "f1c10fa9c445cb9f300266122ef18671054b2330"]},