Support Elixir ~> 1.12 (#478)

Author: ericmj

.github/workflows/main.yml

@@ -22,9 +22,9 @@ jobs:
           # One version down.
           - erlang: "27.2"
             elixir: "1.18"
-          # Oldest version. We technically support OTP 23 but hard to test in CI
+          # Oldest version.
           - erlang: "24.3"
-            elixir: "1.15"
+            elixir: "1.12.3"
 
     env:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

lib/mint/application.ex

@@ -601,18 +601,14 @@ defmodule Mint.Core.Transport.SSL do
   end
 
   defp get_cacertfile(path) do
-    if Application.get_env(:mint, :persistent_term) do
-      case :persistent_term.get({:mint, {:cacertfile, path}}, :error) do
-        {:ok, cacerts} ->
-          cacerts
-
-        :error ->
-          cacerts = decode_cacertfile(path)
-          :persistent_term.put({:mint, {:cacertfile, path}}, {:ok, cacerts})
-          cacerts
-      end
-    else
-      decode_cacertfile(path)
+    case :persistent_term.get({:mint, {:cacertfile, path}}, :error) do
+      {:ok, cacerts} ->
+        cacerts
+
+      :error ->
+        cacerts = decode_cacertfile(path)
+        :persistent_term.put({:mint, {:cacertfile, path}}, {:ok, cacerts})
+        cacerts
     end
   end
 

lib/mint/core/transport/ssl.ex

@@ -762,7 +762,7 @@ defmodule Mint.HTTP1 do
         {:ok, conn, responses}
 
       length <= byte_size(data) ->
-        <<body::binary-size(^length), rest::binary>> = data
+        {body, rest} = :erlang.split_binary(data, length)
         {conn, responses} = add_body(conn, body, responses)
         conn = request_done(conn)
         responses = [{:done, request_ref} | responses]
@@ -836,7 +836,7 @@ defmodule Mint.HTTP1 do
         {:ok, conn, responses}
 
       length <= byte_size(data) ->
-        <<body::binary-size(^length), rest::binary>> = data
+        {body, rest} = :erlang.split_binary(data, length)
         {conn, responses} = add_body(conn, body, responses)
         conn = put_in(conn.request.body, {:chunked, :crlf})
         decode_body({:chunked, :crlf}, conn, rest, request_ref, responses)

lib/mint/http1.ex

@@ -1266,7 +1266,7 @@ defmodule Mint.HTTP2 do
   end
 
   defp split_payload_in_chunks(binary, chunk_size, acc) do
-    <<chunk::size(^chunk_size)-binary, rest::binary>> = binary
+    {chunk, rest} = :erlang.split_binary(binary, chunk_size)
     split_payload_in_chunks(rest, chunk_size, [chunk | acc])
   end
 

lib/mint/http2.ex

@@ -271,7 +271,7 @@ defmodule Mint.HTTP2.Frame do
     else
       # 1 byte is for the space taken by pad_length
       data_length = byte_size(payload) - pad_length - 1
-      <<data::size(^data_length)-binary, padding::size(^pad_length)-binary>> = rest
+      {data, padding} = :erlang.split_binary(rest, data_length)
       {data, padding}
     end
   end

lib/mint/http2/frame.ex

@@ -8,15 +8,14 @@ defmodule Mint.MixProject do
     [
       app: :mint,
       version: @version,
-      elixir: "~> 1.15",
+      elixir: "~> 1.12",
       start_permanent: Mix.env() == :prod,
       elixirc_paths: elixirc_paths(Mix.env()),
       deps: deps(),
 
       # Xref
       xref: [
         exclude: [
-          :persistent_term,
           {:ssl, :cipher_suites, 1},
           {:public_key, :cacerts_get, 0},
           CAStore
@@ -54,8 +53,7 @@ defmodule Mint.MixProject do
   # Run "mix help compile.app" to learn about applications.
   def application do
     [
-      extra_applications: [:logger, :ssl],
-      mod: {Mint.Application, []}
+      extra_applications: [:logger, :ssl]
     ]
   end
 

mix.exs

@@ -90,7 +90,7 @@ defmodule Mint.HTTP1.PropertiesTest do
       |> Enum.sort()
       |> Enum.reduce({[], binary, 0}, fn split, {chunks, rest, prev_split} ->
         length = split - prev_split
-        <<chunk::binary-size(^length), rest::binary>> = rest
+        {chunk, rest} = :erlang.split_binary(rest, length)
         {[chunk | chunks], rest, split}
       end)
       |> join_last_chunk()