Fix crash when creating tensor from empty buffer in whisper#454
Open
kidq330 wants to merge 2 commits intoelixir-nx:mainfrom
Open
Fix crash when creating tensor from empty buffer in whisper#454kidq330 wants to merge 2 commits intoelixir-nx:mainfrom
kidq330 wants to merge 2 commits intoelixir-nx:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've run into an issue when my audio tensor is exactly aligned with the chunk length for the Whisper serving, here's an MRE script:
Output (same with e.g.
chunk_num_seconds = 20):I've only run into this issue when disabling overlapping with
context_num_seconds: 0, since it would be hard to align the windows length with the default value of 1/6th of the chunk length.