Makefile: make MLX_SO overridable#111
Open
GenericJam wants to merge 1 commit into
Open
Conversation
Lets downstream callers point at a different MLX artifact (e.g.
libmlx.a for iOS static linking) without editing the Makefile:
MLX_SO=$(MLX_LIB_DIR)/libmlx.a make
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per suggestion in Slack: change
MLX_SO = ...toMLX_SO ?= ...onemlx/Makefile:12so downstream callers can point at a different MLX artifact (e.g.libmlx.afor iOS static linking, where the OS won'tdlopenfrom app data) without editing the Makefile:Tiny, mechanical change. The current Linux/macOS dynamic-link defaults are unchanged.
Context: we (mob) are building EMLX against a static
libmlx.afor iOS device + simulator targets, alongside an MLX iOS+Metal patch we'd like to upstream intococoa-xu/mlx-build. This?=change is the minimal unlock that lets EMLX itself participate in that pipeline without a vendored fork.Human edit: this PR is made by Claude at my direction. Not offended if AI PRs are rejected.