Fix exotic candidate resolution

Author: dannote

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.7.1
+
+### Fixed
+
+- Skip package versions with blocked transitive exotic dependencies during dependency solving instead of aborting resolution before a safe version can be selected.
+
 ## 0.7.0
 
 ### Breaking changes

lib/npm/resolver.ex

@@ -256,8 +256,10 @@ defmodule NPM.Resolver do
 
   defp parse_sorted_versions(packument) do
     packument.versions
-    |> Map.keys()
-    |> Enum.flat_map(fn v ->
+    |> Enum.reject(fn {version_str, info} ->
+      exotic_candidate?(packument.name, version_str, info)
+    end)
+    |> Enum.flat_map(fn {v, _info} ->
       case Version.parse(v) do
         {:ok, version} -> [version]
         :error -> []
@@ -266,6 +268,13 @@ defmodule NPM.Resolver do
     |> Enum.sort(Version)
   end
 
+  defp exotic_candidate?(package, version_str, info) do
+    ExoticDeps.validate!(package, version_str, info)
+    false
+  rescue
+    ExoticDeps.Error -> true
+  end
+
   defp deps_for_version(package, packument, version_str) do
     excluded = get_excluded()
 

mix.exs

@@ -1,7 +1,7 @@
 defmodule NPM.MixProject do
   use Mix.Project
 
-  @version "0.7.0"
+  @version "0.7.1"
   @source_url "https://github.com/elixir-volt/npm_ex"
 
   def project do

test/npm/resolver_exotic_candidate_test.exs

@@ -0,0 +1,56 @@
+defmodule NPM.ResolverExoticCandidateTest do
+  use ExUnit.Case, async: false
+
+  @table :npm_resolver_cache
+
+  setup do
+    NPM.Resolver.clear_cache()
+    ensure_table!()
+
+    on_exit(fn -> NPM.Resolver.clear_cache() end)
+
+    :ok
+  end
+
+  test "versions excludes candidates with blocked transitive exotic dependencies" do
+    package = "__exotic_filter__"
+
+    :ets.insert(@table, {
+      package,
+      %{
+        name: package,
+        versions: %{
+          "1.0.0" => version_info(%{"payload" => "file:./payload"}),
+          "1.0.1" => version_info(%{})
+        }
+      }
+    })
+
+    assert {:ok, versions} = NPM.Resolver.versions(nil, package)
+    assert versions == [Version.parse!("1.0.1")]
+  end
+
+  defp version_info(dependencies) do
+    %{
+      dependencies: dependencies,
+      optional_dependencies: %{},
+      peer_dependencies: %{},
+      peer_dependencies_meta: %{},
+      bin: %{},
+      engines: %{},
+      os: [],
+      cpu: [],
+      has_install_script: false,
+      deprecated: nil,
+      created_at: nil,
+      published_at: nil,
+      dist: %{tarball: "", integrity: "", file_count: nil, unpacked_size: nil}
+    }
+  end
+
+  defp ensure_table! do
+    if :ets.whereis(@table) == :undefined do
+      :ets.new(@table, [:named_table, :set, :public])
+    end
+  end
+end