Fix manifest decoding

Author: dannote

lib/phoenix_iconify/manifest.ex

@@ -108,7 +108,7 @@ defmodule PhoenixIconify.Manifest do
   end
 
   defp decode!(json) do
-    %{version: @version, icons: icons} = Jason.decode!(json, keys: :atoms!)
+    %{"version" => @version, "icons" => icons} = Jason.decode!(json)
 
     unless is_list(icons) do
       raise ArgumentError, "invalid PhoenixIconify manifest: expected icons to be a list"
@@ -117,8 +117,30 @@ defmodule PhoenixIconify.Manifest do
     Map.new(icons, &icon_entry/1)
   end
 
-  defp icon_entry(icon) do
-    icon = struct!(Iconify.Icon, icon)
+  defp icon_entry(icon) when is_map(icon) do
+    icon = struct!(Iconify.Icon, normalize_icon(icon))
     {icon.name, icon}
   end
+
+  defp normalize_icon(icon) do
+    %{
+      name: required_icon_value(icon, "name"),
+      body: required_icon_value(icon, "body"),
+      width: Map.get(icon, "width", 16),
+      height: Map.get(icon, "height", 16),
+      left: Map.get(icon, "left", 0),
+      top: Map.get(icon, "top", 0),
+      rotate: Map.get(icon, "rotate", 0),
+      h_flip: Map.get(icon, "h_flip", false),
+      v_flip: Map.get(icon, "v_flip", false),
+      hidden: Map.get(icon, "hidden", false)
+    }
+  end
+
+  defp required_icon_value(icon, key) do
+    case Map.fetch(icon, key) do
+      {:ok, value} -> value
+      :error -> raise ArgumentError, "invalid PhoenixIconify manifest: icon missing #{key}"
+    end
+  end
 end

test/phoenix_iconify/manifest_test.exs

@@ -32,6 +32,24 @@ defmodule PhoenixIconify.ManifestTest do
       end
     end
 
+    test "reads manifests before icon field atoms exist" do
+      path =
+        Path.join(System.tmp_dir!(), "test_manifest_strings_#{:rand.uniform(1_000_000)}.json")
+
+      try do
+        File.write!(
+          path,
+          ~s({"version":1,"icons":[{"name":"lucide:sun","body":"<path/>","width":24,"height":24}]})
+        )
+
+        assert %{"lucide:sun" => icon} = Manifest.read(path)
+        assert icon.width == 24
+        assert icon.height == 24
+      after
+        File.rm(path)
+      end
+    end
+
     test "returns empty map for missing file" do
       assert Manifest.read("/nonexistent/path.json") == %{}
     end