Exclude Base64 padding from ICEAgent credentials (#98)

Author: olegokunevych

lib/ex_ice/priv/ice_agent.ex

@@ -2700,8 +2700,8 @@ defmodule ExICE.Priv.ICEAgent do
   end
 
   defp generate_credentials() do
-    ufrag = :crypto.strong_rand_bytes(3) |> Base.encode64()
-    pwd = :crypto.strong_rand_bytes(16) |> Base.encode64()
+    ufrag = :crypto.strong_rand_bytes(3) |> Base.encode64(padding: false)
+    pwd = :crypto.strong_rand_bytes(16) |> Base.encode64(padding: false)
     {ufrag, pwd}
   end
 

test/priv/ice_agent_test.exs

@@ -3063,6 +3063,23 @@ defmodule ExICE.Priv.ICEAgentTest do
     assert <<_channel_number::16, _len::16, "somedata">> = packet
   end
 
+  describe "generate_credentials/0" do
+    test "generates credentials without padding" do
+      ice_agent =
+        ICEAgent.new(
+          controlling_process: self(),
+          role: :controlling,
+          if_discovery_module: IfDiscovery.MockSingle,
+          transport_module: Transport.Mock
+        )
+
+      refute String.contains?(ice_agent.local_ufrag, "=")
+      refute String.contains?(ice_agent.local_pwd, "=")
+      assert byte_size(ice_agent.local_ufrag) == 4
+      assert byte_size(ice_agent.local_pwd) == 22
+    end
+  end
+
   defp connect(ice_agent) do
     [socket] = ice_agent.sockets
     [remote_cand] = Map.values(ice_agent.remote_cands)