Skip to content

Fix compile warnings, bump deps+CI#105

Merged
sgfn merged 1 commit into
masterfrom
fix/compile-warnings
Jun 16, 2026
Merged

Fix compile warnings, bump deps+CI#105
sgfn merged 1 commit into
masterfrom
fix/compile-warnings

Conversation

@sgfn

@sgfn sgfn commented Jun 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@sgfn
sgfn requested a review from Karolk99 June 10, 2026 12:01
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.21%. Comparing base (d230a73) to head (2087f93).

Files with missing lines Patch % Lines
lib/ex_ice/priv/ice_agent.ex 84.93% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   87.35%   87.21%   -0.14%     
==========================================
  Files          27       27              
  Lines        2095     2127      +32     
==========================================
+ Hits         1830     1855      +25     
- Misses        265      272       +7     
Files with missing lines Coverage Δ
lib/ex_ice/ice_agent.ex 73.26% <ø> (+2.53%) ⬆️
lib/ex_ice/priv/candidate_pair.ex 100.00% <100.00%> (ø)
lib/ex_ice/priv/checklist.ex 100.00% <100.00%> (ø)
lib/ex_ice/priv/conn_check_handler/controlled.ex 94.00% <100.00%> (-0.12%) ⬇️
lib/ex_ice/priv/conn_check_handler/controlling.ex 86.76% <100.00%> (-0.38%) ⬇️
lib/ex_ice/priv/gatherer.ex 96.10% <ø> (+0.10%) ⬆️
lib/ex_ice/priv/transport/tcp.ex 92.30% <ø> (ø)
lib/ex_ice/priv/ice_agent.ex 89.05% <84.93%> (-0.05%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d230a73...2087f93. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgfn
sgfn merged commit b0de12e into master Jun 16, 2026
4 checks passed
@sgfn
sgfn deleted the fix/compile-warnings branch June 16, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants