Skip to content

Fix crash on send error and keepalive response on pruned pair, release 0.16.0#107

Merged
sgfn merged 1 commit into
masterfrom
fix/tolerate-send-errors
Jun 22, 2026
Merged

Fix crash on send error and keepalive response on pruned pair, release 0.16.0#107
sgfn merged 1 commit into
masterfrom
fix/tolerate-send-errors

Conversation

@sgfn

@sgfn sgfn commented Jun 15, 2026

Copy link
Copy Markdown
Member

two fixes included

  • :ok = matches for transport_mod.send on several TURN messages
  • crash on keepalive response on pruned pair

@sgfn sgfn changed the title wip Tolerate send errors Jun 15, 2026
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.57%. Comparing base (b0de12e) to head (d5e8112).

Files with missing lines Patch % Lines
lib/ex_ice/priv/ice_agent.ex 81.57% 7 Missing ⚠️
test/support/transport/mock.ex 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   87.11%   87.57%   +0.45%     
==========================================
  Files          27       27              
  Lines        2127     2140      +13     
==========================================
+ Hits         1853     1874      +21     
+ Misses        274      266       -8     
Files with missing lines Coverage Δ
test/support/transport/mock.ex 79.54% <62.50%> (-4.24%) ⬇️
lib/ex_ice/priv/ice_agent.ex 89.76% <81.57%> (+0.88%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0de12e...d5e8112. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from fix/compile-warnings to master June 16, 2026 11:33
@sgfn
sgfn force-pushed the fix/tolerate-send-errors branch 2 times, most recently from bf4aab9 to 49b4be8 Compare June 16, 2026 12:01
@sgfn sgfn changed the title Tolerate send errors Fix crash on send error and keepalive response on pruned pair, release 0.16.0 Jun 16, 2026
@sgfn
sgfn marked this pull request as ready for review June 16, 2026 12:01
@sgfn
sgfn requested a review from Karolk99 June 16, 2026 12:01
@sgfn
sgfn force-pushed the fix/tolerate-send-errors branch from 49b4be8 to d5e8112 Compare June 16, 2026 12:03
@sgfn
sgfn merged commit 4049deb into master Jun 22, 2026
4 checks passed
@sgfn
sgfn deleted the fix/tolerate-send-errors branch June 22, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants