car_diff: dedupe errors and render in dropdown#479
Closed
elkoled wants to merge 6 commits into
Closed
Conversation
A single failing carcontroller raised the same traceback for every segment, printing dozens of identical tracebacks at the top of the report. Group errors by their text, print each unique one once with the affected segment count, and wrap the whole block in a details dropdown like the diff section so it does not spam the PR comment. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 50 segments for: NISSAN_XTRAIL, NISSAN_LEAF, NISSAN_LEAF_IC, NISSAN_ROGUE, NISSAN_ALTIMA Show errorsShow changes |
Owner
Author
|
Superseded by #480 (minimal, on latest master). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test of car_diff hardening on the fork. This branch keeps the buggy nissan PR (commaai#3409) carstate so the replay still errors on the 4 non-Altima platforms, exercising the new error path.
Expected: instead of ~40 identical tracebacks printed at the top, the report shows a single collapsible 'Show errors' dropdown with the traceback deduped and tagged (40x).
🤖 Generated with Claude Code