Skip to content

Commit 7faf9ff

Browse files
Pluralize domain and path label in deep links panel (flutter#9790)
* Pluralize domain label in deep links panel * Fix pluralization Path notification * Update release notes for deep links tool Pluralized 'domain' and 'path' in validation summary notification titles. * Update packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com> * Fix formatting --------- Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com>
1 parent aac691b commit 7faf9ff

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

packages/devtools_app/lib/src/screens/deep_link_validation/deep_link_list_view.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
44

55
import 'package:devtools_app_shared/ui.dart';
6+
import 'package:devtools_app_shared/utils.dart';
67
import 'package:flutter/foundation.dart';
78
import 'package:flutter/material.dart';
89

@@ -439,7 +440,8 @@ class _NotificationCardSection extends StatelessWidget {
439440
children: [
440441
if (domainErrorCount > 0)
441442
NotificationCard(
442-
title: '$domainErrorCount domain not verified',
443+
title:
444+
'$domainErrorCount ${pluralize('domain', domainErrorCount)} not verified',
443445
description:
444446
'This affects all deep links. Fix issues to make users go directly to your app.',
445447
actionButton: TextButton(
@@ -461,7 +463,8 @@ class _NotificationCardSection extends StatelessWidget {
461463
const SizedBox(width: defaultSpacing),
462464
if (pathErrorCount > 0)
463465
NotificationCard(
464-
title: '$pathErrorCount path not working',
466+
title:
467+
'$pathErrorCount ${pluralize('path', pathErrorCount)} not working',
465468
description:
466469
'Fix these path to make sure users are directed to your app',
467470
actionButton: TextButton(

packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ TODO: Remove this section if there are not any updates.
5858

5959
## Deep links tool updates
6060

61-
TODO: Remove this section if there are not any updates.
61+
- Pluralized "domain" and "path" in the validation summary notification titles when multiple errors are present. [#9790](https://github.com/flutter/devtools/pull/9790)
6262

6363
## VS Code sidebar updates
6464

0 commit comments

Comments
 (0)