Address memory leaks with search and filter code (flutter#8975)

Author: kenzieschmoll

packages/devtools_app/lib/src/framework/scaffold/status_line.dart

@@ -76,6 +76,8 @@ class StatusLine extends StatelessWidget {
     final theme = Theme.of(context);
     final color = highlightForConnection ? theme.colorScheme.onPrimary : null;
     final screenWidth = ScreenSize(context).width;
+    // TODO(https://github.com/flutter/devtools/issues/8913): this builds the
+    // wrong status items for offline mode.
     final pageStatus = currentScreen.buildStatus(context);
     final widerThanXxs = screenWidth > MediaSize.xxs;
     final screenMetaData = ScreenMetaData.lookup(currentScreen.screenId);

packages/devtools_app/lib/src/screens/app_size/app_size_screen.dart

@@ -143,8 +143,8 @@ class _AppSizeBodyState extends State<AppSizeBody>
 
   @override
   void dispose() {
-    super.dispose();
     _tabController.dispose();
+    super.dispose();
   }
 
   void _pushErrorMessage(String error) {

packages/devtools_app/lib/src/screens/debugger/codeview.dart

@@ -155,7 +155,6 @@ class _CodeViewState extends State<CodeView> with AutoDisposeMixin {
 
     if (widget.codeViewController != oldWidget.codeViewController) {
       cancelListeners();
-      widget.codeViewController.initSearch();
       addAutoDisposeListener(
         widget.codeViewController.scriptLocation,
         _handleScriptLocationChanged,

packages/devtools_app/lib/src/screens/debugger/file_search.dart

@@ -30,7 +30,7 @@ class FileSearchField extends StatefulWidget {
 }
 
 class FileSearchFieldState extends State<FileSearchField>
-    with AutoDisposeMixin, SearchFieldMixin {
+    with AutoDisposeMixin {
   static final fileSearchFieldKey = GlobalKey(debugLabel: 'fileSearchFieldKey');
 
   final autoCompleteController = AutoCompleteController(fileSearchFieldKey);
@@ -40,9 +40,6 @@ class FileSearchFieldState extends State<FileSearchField>
   late String _query;
   late FileSearchResults _searchResults;
 
-  @override
-  SearchControllerMixin get searchController => autoCompleteController;
-
   @override
   void initState() {
     super.initState();

packages/devtools_app/lib/src/screens/inspector/inspector_screen_body.dart

@@ -37,10 +37,7 @@ class InspectorScreenBody extends StatefulWidget {
 }
 
 class InspectorScreenBodyState extends State<InspectorScreenBody>
-    with
-        BlockingActionMixin,
-        AutoDisposeMixin,
-        SearchFieldMixin<InspectorScreenBody> {
+    with BlockingActionMixin, AutoDisposeMixin {
   InspectorController get controller => widget.controller;
 
   InspectorTreeController get _summaryTreeController =>
@@ -51,7 +48,6 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>
 
   bool searchVisible = false;
 
-  @override
   SearchControllerMixin get searchController => _summaryTreeController;
 
   /// Indicates whether search can be closed. The value is set to true when

packages/devtools_app/lib/src/screens/inspector_v2/inspector_screen_body.dart

@@ -35,18 +35,14 @@ class InspectorScreenBody extends StatefulWidget {
 }
 
 class InspectorScreenBodyState extends State<InspectorScreenBody>
-    with
-        BlockingActionMixin,
-        AutoDisposeMixin,
-        SearchFieldMixin<InspectorScreenBody> {
+    with BlockingActionMixin, AutoDisposeMixin {
   InspectorController get controller => widget.controller;
 
   InspectorTreeController get _inspectorTreeController =>
       controller.inspectorTree;
 
   bool searchVisible = false;
 
-  @override
   SearchControllerMixin get searchController => _inspectorTreeController;
 
   /// Indicates whether search can be closed. The value is set to true when

packages/devtools_app/lib/src/screens/logging/logging_controller.dart

@@ -123,7 +123,6 @@ class LoggingController extends DevToolsScreenController
       _handleConnectionStart(serviceConnection.serviceManager.service!);
     }
     _handleBusEvents();
-    initFilterController();
 
     addAutoDisposeListener(
       preferences.logging.retentionLimit,

packages/devtools_app/lib/src/screens/network/network_controller.dart

@@ -138,7 +138,8 @@ class NetworkController extends DevToolsScreenController
   }
 
   final selectedRequest = ValueNotifier<NetworkRequest?>(null);
-  late CurrentNetworkRequests _currentNetworkRequests;
+
+  final _currentNetworkRequests = CurrentNetworkRequests();
 
   /// Notifies that the timeline is currently being recorded.
   ValueListenable<bool> get recordingNotifier => _recordingNotifier;
@@ -169,13 +170,11 @@ class NetworkController extends DevToolsScreenController
   @override
   void init() {
     super.init();
-    _currentNetworkRequests = CurrentNetworkRequests();
     _initHelper();
     addAutoDisposeListener(
       _currentNetworkRequests,
       _filterAndRefreshSearchMatches,
     );
-    initFilterController();
   }
 
   @override

packages/devtools_app/lib/src/screens/profiler/cpu_profiler_controller.dart

@@ -48,9 +48,7 @@ class CpuProfilerController extends DisposableController
         FilterControllerMixin<CpuStackFrame>,
         AutoDisposeControllerMixin {
   CpuProfilerController() {
-    // TODO(https://github.com/flutter/devtools/issues/7727): add support for
-    // persisting cpu profiler filter.
-    initFilterController();
+    super.init();
   }
 
   /// Tag to represent when no user tag filters are applied.

packages/devtools_app/lib/src/screens/profiler/panes/method_table/method_table_controller.dart

@@ -23,12 +23,20 @@ class MethodTableController extends DisposableController
   MethodTableController({
     required ValueListenable<CpuProfileData?> dataNotifier,
   }) {
+    super.init();
     createMethodTableGraph(dataNotifier.value);
     addAutoDisposeListener(dataNotifier, () {
       createMethodTableGraph(dataNotifier.value);
     });
   }
 
+  @override
+  void dispose() {
+    selectedNode.dispose();
+    _methods.dispose();
+    super.dispose();
+  }
+
   final selectedNode = ValueNotifier<MethodTableGraphNode?>(null);
 
   ValueListenable<List<MethodTableGraphNode>> get methods => _methods;