Fix/client disconnect as parsing error#9
Open
hbrooks wants to merge 3 commits into
Open
Conversation
… parsing error When a client disconnects while FastAPI is reading the request body, Starlette raises ClientDisconnect. The broad `except Exception` handler in the body reading code was catching this and converting it into HTTPException(400, "There was an error parsing the body"), which is misleading and hides the real cause. Add `except ClientDisconnect: raise` before the catch-all so the exception propagates correctly instead of being misclassified as a parsing error. https://claude.ai/code/session_01VuoZZMnmCx4FKbtkaUUPwJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally PR fastapi#15315 in fastapi/fastapi by @AlePiccin