cmd/go: propagate GOTMPDIR to subprocess temp directory variables#19
Open
hbrooks wants to merge 1 commit into
Open
cmd/go: propagate GOTMPDIR to subprocess temp directory variables#19hbrooks wants to merge 1 commit into
hbrooks wants to merge 1 commit into
Conversation
When GOTMPDIR is set, the go command uses it to create its own work directory, but subprocesses such as the linker, C compiler, and cgo still use the system default temporary directory. This is because GOTMPDIR is a Go-specific variable that external tools do not recognize. Fix this by translating GOTMPDIR into the platform-specific temporary directory environment variable (TMPDIR on Unix, TMP/TEMP on Windows) so that all subprocesses respect the user's configured temporary directory. The fix has two layers: - Add TMPDIR to cfgChangedEnv so it is explicitly passed to subprocesses that use it (compiler, assembler, linker, cgo) and is visible in 'go build -x' output. - Call os.Setenv in BuildInit to set the process-level TMPDIR, covering subprocesses that do not receive cfgChangedEnv (C compiler, vet, pkg-config, etc.) via cmd.Environ(). Fixes golang#59636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of golang/go#78679 by @iceymoss