Add multipart/form-data HTTP content factory#7769
Open
Adham-Kiwan wants to merge 1 commit into
Open
Conversation
Elsa.Http provided IHttpContentFactory implementations for JSON, XML, text and application/x-www-form-urlencoded, but there was no writer for multipart/form-data. Add MultipartFormDataHttpContentFactory following the same pattern as FormUrlEncodedHttpContentFactory, register it in the Features and ShellFeatures HttpFeature so it surfaces in the content-type dropdown, and cover it with unit tests. Signed-off-by: Adham Kiwan <adhamkiwan@outlook.com>
Contributor
|
PR author is not in the allowed authors list. |
Author
|
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Elsa.HttpshipsIHttpContentFactoryimplementations for JSON, XML, text andapplication/x-www-form-urlencoded, but there was no writer formultipart/form-data. This addsMultipartFormDataHttpContentFactory, following the same pattern as the existingFormUrlEncodedHttpContentFactory.Closes #75. The
application/x-www-form-urlencodedhalf of that issue already exists viaFormUrlEncodedHttpContentFactory; this completes the remainingmultipart/form-datawriter.Changes
MultipartFormDataHttpContentFactoryinElsa.Http/ContentWriters, converting dictionary /JsonObject/ object content into aMultipartFormDataContentwith one text part per field.Features/HttpFeature.csandShellFeatures/HttpFeature.cs, somultipart/form-dataautomatically appears in theSendHttpRequestactivity's content-type dropdown.ContentFactoryTestscovering the supported content type, boundary generation, per-field parts, andJsonObjectpayloads.Testing
dotnet testforElsa.Http.UnitTests(ContentFactoryTests) — all passing (9/9).