Add a fastboot config for field-guide > 3.0.1#1280
Open
BlueCutOfficial wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1225 introduced a bug in the demo app by upgrading the version of field-guide that was enforced.
History: When field-guide was updated to version
3.0.0in #1273, the exact version3.0.0was enforced by removing^because the patch3.0.1was introducing an error related to thefetchdefinition that was not a priority to investigate at that time. #1225 introduced the bug by upgrading to 3.1.0, greater than 3.0.1.This PR addresses the root cause of the issue, allowing us to keep field-guide 3.1.0 installed.
The meaning of the 3.0.1 patch is that
fetchis now available in Node by default; it's part of the globals, so we no longer need a tool likeember-fetchto define the method. However, the way Fastboot works is peculiar, and the Node globals are not available by default when serving an app with Fastboot. Globals need to be passed explicitly to the Fastboot sandbox, which can be done through a configuration file fastboot.js.