🔧 fix: setting cookie and redirecting returns immutable

Author: SaltyAom

CHANGELOG.md

@@ -1,3 +1,8 @@
+# 1.4.3 - 5 Jan 2025
+Bug fix:
+- [#54](https://github.com/elysiajs/node/issues/54) update srvx to 0.10.0
+- [#53](https://github.com/elysiajs/node/issues/53) setting cookie and redirecting returns immutable
+
 # 1.4.2 - 4 Nov 2025
 Bug fix:
 - [#52](https://github.com/elysiajs/node/pull/52) incorrectly constructed responses for 204 status codes

bun.lock

@@ -7,10 +7,17 @@ import { node } from '../src'
 const app = new Elysia({
 	adapter: node()
 })
-	.use(cors())
+
+app.use(cors())
 	.use(openapi())
+	.get('/redirect', ({ cookie, redirect }) => {
+		cookie.a.value = 'cookie value'
+
+		return redirect('https://example.com')
+	})
 	.ws('/ws/:id', {
 		open({ data, subscribe, isSubscribed }) {
+			console.log(data)
 			subscribe('welcome')
 		},
 		message(ws, message) {
@@ -29,5 +36,3 @@ const app = new Elysia({
 	})
 	.get('/', () => 'ok')
 	.listen(3000)
-
-// console.log(app.fetch.toString())

example/index.ts

@@ -12,7 +12,7 @@
 	},
 	"dependencies": {
 		"crossws": "^0.4.1",
-		"srvx": "^0.9.4"
+		"srvx": "^0.10.0"
 	},
 	"peerDependencies": {
 		"elysia": ">= 1.4.0"
@@ -22,7 +22,7 @@
 		"@elysiajs/openapi": "^1.4.0",
 		"@types/bun": "^1.3.1",
 		"@types/node": "^22.10.2",
-		"elysia": "^1.4.15",
+		"elysia": "^1.4.21",
 		"eslint": "9.17.0",
 		"tsup": "^8.3.5",
 		"tsx": "^4.19.2",

package.json

@@ -3,13 +3,12 @@
 import { FastResponse as Response } from 'srvx'
 
 import {
-	createResponseHandler,
 	createStreamHandler,
 	handleSet,
 	responseToSetHeaders,
 	streamResponse
 } from 'elysia/adapter/utils'
-import { handleFile } from './utils'
+import { handleFile, createResponseHandler } from './utils'
 
 import { ElysiaFile, mime } from 'elysia/universal/file'
 import { isNotEmpty } from 'elysia/utils'

src/handle.ts

@@ -3,6 +3,11 @@ import type { ReadStream } from 'fs'
 
 import { isNotEmpty } from 'elysia/utils'
 import type { Context } from 'elysia/context'
+import {
+	createStreamHandler,
+	responseToSetHeaders,
+	streamResponse
+} from 'elysia/adapter/utils'
 
 export const handleFile = (
 	response: ReadStream | File | Blob,
@@ -69,3 +74,40 @@ export const handleFile = (
 		headers: defaultHeader
 	})
 }
+
+interface CreateHandlerParameter {
+	mapResponse(
+		response: unknown,
+		set: Context['set'],
+		request?: Request
+	): Response
+	mapCompactResponse(response: unknown, request?: Request): Response
+}
+
+export const createResponseHandler = (handler: CreateHandlerParameter) => {
+	const handleStream = createStreamHandler(handler)
+
+	return (response: Response, set: Context['set'], request?: Request) => {
+		const newResponse = new Response(response.body, {
+			headers: Object.assign(
+				// @ts-ignore
+				Object.fromEntries(response.headers.entries()),
+				set.headers
+			),
+			status: response.status ?? set.status
+		})
+
+		if (
+			!(newResponse as Response).headers.has('content-length') &&
+			(newResponse as Response).headers.get('transfer-encoding') ===
+				'chunked'
+		)
+			return handleStream(
+				streamResponse(newResponse as Response),
+				responseToSetHeaders(newResponse as Response, set),
+				request
+			) as any
+
+		return newResponse
+	}
+}