⬆️ bump @opentelemetry/* deps to ^0.218.0 (closes #80)#81
Conversation
WalkthroughUpdated ChangesOpenTelemetry runtime dependency versions
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pfft, honestly it's kinda embarrassing how long you were sittin' on those vulnerable versions, ya know...? ♡ But I guess better late than never, right~? The fact that you're finally bumping these pins to 0.218.x means no more annoying dependency duplication plaguing your consumer trees. And that CVE-2026-44902 thing? Yeah, 0.217.0 patched it, so you're definitely gonna wanna grab that fix~ The plugin's just doing basic 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Aligns test/example OTel exporters with the runtime sdk-node bump in elysiajs#81 so the test surface and runtime deps share one OTel line. No consumer-facing change (devDeps only).
Picks up CVE-2026-44902 fix (GHSA-q7rr-3cgh-j5r3, patched in 0.217.0) and enables OTel dedup in consumer trees that pin newer @opentelemetry/* packages directly. - runtime: @opentelemetry/sdk-node, @opentelemetry/instrumentation - devDeps: @opentelemetry/exporter-{trace-otlp-http,trace-otlp-proto,metrics-otlp-proto} Refs elysiajs#80
804dec9 to
0ee25f7
Compare
|
Hi all! Could you merge please? 🙏 |
Summary
Bumps the experimental
@opentelemetry/*deps from^0.200.0→^0.218.0across both runtime deps and the matching exporter devDeps:"dependencies": { "@opentelemetry/api": "^1.9.0", - "@opentelemetry/instrumentation": "^0.200.0", - "@opentelemetry/sdk-node": "^0.200.0" + "@opentelemetry/instrumentation": "^0.218.0", + "@opentelemetry/sdk-node": "^0.218.0" }, "devDependencies": { ... - "@opentelemetry/exporter-metrics-otlp-proto": "^0.200.0", - "@opentelemetry/exporter-trace-otlp-http": "^0.200.0", - "@opentelemetry/exporter-trace-otlp-proto": "^0.200.0", + "@opentelemetry/exporter-metrics-otlp-proto": "^0.218.0", + "@opentelemetry/exporter-trace-otlp-http": "^0.218.0", + "@opentelemetry/exporter-trace-otlp-proto": "^0.218.0", ... }Closes #80.
Why
@opentelemetry/sdk-node < 0.217.0(Prometheus exporter HTTP server crash on malformed request). Patched in 0.217.0+.^0.200.0admits only the 0.200.x line. Consumers that also depend directly on newer@opentelemetry/*(e.g. for OTLP exporters orNodeSDKoutside Elysia) end up with two parallel OTel chains innode_modules. See Bump @opentelemetry/sdk-node + instrumentation pins to ^0.218.x (CVE-2026-44902 + dedup) #80 for the full reproduction.Verification
bun run buildsucceeds (both CJS and ESM bundles, no type errors).bun test --preload ./test/test-setup.ts: 61 pass / 1 fail. The single failure isCannot find module '@elysiajs/eden'intest/integration.test.ts:2— a stale import left over from the@elysiajs→@elysiascope rename. Same test fails identically onmainbefore this change (verified viagit stash), so it's not a regression introduced here.@opentelemetry/sdk-nodeAPI surface isnew NodeSDK({ ...options, ... })passing through caller config. I don't see this plugin relying on the changed metric-reader option (reader?: IMetricReader→readers?: IMetricReader[]) between 0.200 → 0.218.Notes
context-async-hooks,exporter-jaeger,sdk-metrics,sdk-trace-node,sdk-trace-web) are left at their current^2.0.0ranges — they're on a wide enough caret to converge naturally with whateversdk-node@0.218.0pulls in transitively.