Test indentation of the PHP 8.5 pipe operator and clone-with

PHP 8.5 adds two constructs that reach the indentation engine:

  $slug = $title
      |> trim(...)
      |> strtolower(...);

  return clone($this, [
      'alpha' => $alpha,
  ]);

The pipe operator starts a continuation line with an operator, and
"clone with" gives `clone' -- until now a bare prefix keyword -- an
argument list.  Both already indent correctly: `|>' matches
php-indent--indent-operator-re, so a line starting with it is a
statement continuation, and `clone(...)' is just a call as far as the
bracket handling is concerned.  Pin that down before it regresses.

The fixtures cover the pipe at the top level, on the same line as the
assignment, inside a function body, inside an argument list, and piping
into static and instance methods; and clone-with inline, with a broken
argument list, and next to a plain `clone $obj'.

Verified the tests have teeth: flattening every line's leading
whitespace and reindenting restores all 35 checked lines.

See https://www.php.net/releases/8.5/en.php

Author: zonuexe

tests/8.5/clone-with.php

@@ -0,0 +1,43 @@
+<?php
+
+/**
+ * PHP 8.5: `clone' with a second argument ("clone with").
+ *
+ * @see https://www.php.net/releases/8.5/en.php
+ */
+
+// The example from the release announcement.
+readonly class Color
+{
+    public function __construct(                     // ###php-mode-test### ((indent 4))
+        public int $red,                             // ###php-mode-test### ((indent 8))
+        public int $green,                           // ###php-mode-test### ((indent 8))
+        public int $blue,                            // ###php-mode-test### ((indent 8))
+        public int $alpha = 255,                     // ###php-mode-test### ((indent 8))
+    ) {}                                             // ###php-mode-test### ((indent 4))
+
+    public function withAlpha(int $alpha): self      // ###php-mode-test### ((indent 4))
+    {                                                // ###php-mode-test### ((indent 4))
+        return clone($this, [                        // ###php-mode-test### ((indent 8))
+            'alpha' => $alpha,                       // ###php-mode-test### ((indent 12))
+        ]);                                          // ###php-mode-test### ((indent 8))
+    }                                                // ###php-mode-test### ((indent 4))
+}
+
+$blue = new Color(79, 91, 147);
+$transparentBlue = $blue->withAlpha(128);
+
+// All on one line.
+$copy = clone($blue, ['alpha' => 0]);                // ###php-mode-test### ((indent 0))
+
+// Plain `clone' keeps working.
+$plain = clone $blue;                                // ###php-mode-test### ((indent 0))
+
+// The argument list broken across lines.
+$other = clone(
+    $blue,                                           // ###php-mode-test### ((indent 4))
+    [                                                // ###php-mode-test### ((indent 4))
+        'red' => 0,                                  // ###php-mode-test### ((indent 8))
+        'green' => 0,                                // ###php-mode-test### ((indent 8))
+    ],                                               // ###php-mode-test### ((indent 4))
+);                                                   // ###php-mode-test### ((indent 0))

tests/8.5/pipe-operator.php

@@ -0,0 +1,40 @@
+<?php
+
+/**
+ * PHP 8.5: the pipe operator `|>'.
+ *
+ * @see https://www.php.net/releases/8.5/en.php
+ */
+
+// The example from the release announcement.
+$title = ' PHP 8.5 Released ';
+
+$slug = $title
+    |> trim(...)                                     // ###php-mode-test### ((indent 4))
+    |> (fn($str) => str_replace(' ', '-', $str))     // ###php-mode-test### ((indent 4))
+    |> (fn($str) => str_replace('.', '', $str))      // ###php-mode-test### ((indent 4))
+    |> strtolower(...);                              // ###php-mode-test### ((indent 4))
+
+// A pipe starting on the same line as the assignment.
+$result = $input |> trim(...)                        // ###php-mode-test### ((indent 0))
+    |> strtolower(...);                              // ###php-mode-test### ((indent 4))
+
+// Inside a function body.
+function slugify(string $title): string
+{
+    return $title                                    // ###php-mode-test### ((indent 4))
+        |> trim(...)                                 // ###php-mode-test### ((indent 8))
+        |> strtolower(...);                          // ###php-mode-test### ((indent 8))
+}
+
+// Inside an argument list.
+var_dump(
+    $title                                           // ###php-mode-test### ((indent 4))
+        |> trim(...)                                 // ###php-mode-test### ((indent 8))
+        |> strtolower(...),                          // ###php-mode-test### ((indent 8))
+);                                                   // ###php-mode-test### ((indent 0))
+
+// Piping into a static method and a method call.
+$out = $data
+    |> Formatter::normalize(...)                     // ###php-mode-test### ((indent 4))
+    |> $encoder->encode(...);                        // ###php-mode-test### ((indent 4))

tests/php-mode-test.el

@@ -819,6 +819,14 @@ The fixture deliberately contains a syntactically invalid declaration
   "Test highlighting language constructs added in PHP 8.4."
   (with-php-mode-test ("8.4/property-hooks.php" :faces t)))
 
+(ert-deftest php-mode-test-php85 ()
+  "Test indentation of language constructs added in PHP 8.5.
+
+The pipe operator `|>' introduces a continuation line that starts with
+an operator, and \"clone with\" gives `clone' an argument list."
+  (with-php-mode-test ("8.5/pipe-operator.php" :indent t :magic t))
+  (with-php-mode-test ("8.5/clone-with.php" :indent t :magic t)))
+
 (ert-deftest php-mode-test-lang ()
   "Test highlighting for language constructs."
   (with-php-mode-test ("lang/class/anonymous-class.php" :indent t :magic t :faces t))