Skip to content

Commit 9043135

Browse files
committed
Ship php-flymake.el and php-align.el in the package
Neither file was listed in Eask's `files', so neither ended up in the built package. php-mode.el requires php-flymake at load time, which makes the result unusable: $ eask package /tmp/dist $ tar xf /tmp/dist/php-mode-1.26.1.tar && cd php-mode-1.26.1 $ emacs -Q --batch -L . --eval "(require 'php-mode)" Eager macro-expansion failure: (file-missing "Cannot open load file" "No such file or directory" "php-flymake") php-flymake.el has been missing from the list since it was added in dc67eae, and php-align.el since the move into lisp/ in cc63080. CI never caught it because `eask test ert' runs against the source tree, where both files are on the load path either way. php-align.el is not required by anything -- users load it themselves -- but it is just as much part of the package, and shipping it is the point of it being here. With both listed, the built package loads and php-flymake is defined. The two `rx' warnings php-flymake.el now contributes to `eask compile' are pre-existing.
1 parent 78e2c8b commit 9043135

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

Eask

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,13 @@
1616
"lisp/php-indent.el"
1717
"lisp/php-keywords.el"
1818
"lisp/php-face.el"
19+
"lisp/php-flymake.el"
1920
"lisp/php-format.el"
2021
"lisp/php-project.el"
2122
"lisp/php-local-manual.el"
2223
"lisp/php-ide-phpactor.el"
2324
"lisp/php-ide.el"
25+
"lisp/php-align.el"
2426
"lisp/php-mode-debug.el")
2527

2628
(script "test" "echo \"Error: no test specified\" && exit 1")

0 commit comments

Comments
 (0)