Commit 9043135
committed
Ship php-flymake.el and php-align.el in the package
Neither file was listed in Eask's `files', so neither ended up in the
built package. php-mode.el requires php-flymake at load time, which
makes the result unusable:
$ eask package /tmp/dist
$ tar xf /tmp/dist/php-mode-1.26.1.tar && cd php-mode-1.26.1
$ emacs -Q --batch -L . --eval "(require 'php-mode)"
Eager macro-expansion failure: (file-missing "Cannot open load file"
"No such file or directory" "php-flymake")
php-flymake.el has been missing from the list since it was added in
dc67eae, and php-align.el since the move into lisp/ in cc63080. CI
never caught it because `eask test ert' runs against the source tree,
where both files are on the load path either way.
php-align.el is not required by anything -- users load it themselves --
but it is just as much part of the package, and shipping it is the point
of it being here.
With both listed, the built package loads and php-flymake is defined.
The two `rx' warnings php-flymake.el now contributes to `eask compile'
are pre-existing.1 parent 78e2c8b commit 9043135
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
0 commit comments