Ship php-flymake.el and php-align.el in the package#820
Merged
Conversation
Neither file was listed in Eask's `files', so neither ended up in the
built package. php-mode.el requires php-flymake at load time, which
makes the result unusable:
$ eask package /tmp/dist
$ tar xf /tmp/dist/php-mode-1.26.1.tar && cd php-mode-1.26.1
$ emacs -Q --batch -L . --eval "(require 'php-mode)"
Eager macro-expansion failure: (file-missing "Cannot open load file"
"No such file or directory" "php-flymake")
php-flymake.el has been missing from the list since it was added in
dc67eae, and php-align.el since the move into lisp/ in cc63080. CI
never caught it because `eask test ert' runs against the source tree,
where both files are on the load path either way.
php-align.el is not required by anything -- users load it themselves --
but it is just as much part of the package, and shipping it is the point
of it being here.
With both listed, the built package loads and php-flymake is defined.
The two `rx' warnings php-flymake.el now contributes to `eask compile'
are pre-existing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither file is listed in Eask's
files, so neither ends up in the built package. php-mode.el requires php-flymake at load time, which makes the result unusable:eask fileslisted 14 items; both of these were absent.How it went unnoticed
lisp/in cc63080.eask test ertruns against the source tree, where both files are on the load path either way. Only a package built from thefileslist is broken.eask install/eask packageare broken today.php-align.el is not required by anything — users load it themselves — but it is just as much part of the package, and shipping it is the point of it being here.
Verification
With both listed, the rebuilt package contains them and loads:
make .eask testis green (65 tests),eask compilereports no errors. The tworxanywarnings php-flymake.el now contributes toeask compileare pre-existing in that file.