Skip to content

Commit 188e544

Browse files
committed
Disable warnings-as-errors for external projects
1 parent 2017fa3 commit 188e544

6 files changed

Lines changed: 16 additions & 1 deletion

File tree

cmake/deps.cmake

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,17 @@ if(_itlabai_cxx)
2525
list(APPEND ITLABAI_EXTERNAL_TOOLCHAIN_ARGS -DCMAKE_CXX_COMPILER=${_itlabai_cxx})
2626
endif()
2727

28+
option(ITLABAI_EXTERNAL_WARNINGS_AS_ERRORS "Treat warnings as errors for external projects" OFF)
29+
set(ITLABAI_EXTERNAL_WARNING_ARGS "")
30+
if(NOT ITLABAI_EXTERNAL_WARNINGS_AS_ERRORS)
31+
list(APPEND ITLABAI_EXTERNAL_WARNING_ARGS -DCMAKE_COMPILE_WARNING_AS_ERROR=OFF)
32+
if(MSVC OR (WIN32 AND CMAKE_CXX_COMPILER_ID STREQUAL "Clang"))
33+
list(APPEND ITLABAI_EXTERNAL_WARNING_ARGS -DCMAKE_C_FLAGS=/WX- -DCMAKE_CXX_FLAGS=/WX-)
34+
else()
35+
list(APPEND ITLABAI_EXTERNAL_WARNING_ARGS -DCMAKE_C_FLAGS=-Wno-error -DCMAKE_CXX_FLAGS=-Wno-error)
36+
endif()
37+
endif()
38+
2839
add_custom_target(itlabai_external) # aggregator for externals
2940

3041
include(${CMAKE_CURRENT_LIST_DIR}/deps/tbb.cmake)

cmake/deps/gtest.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ if(NOT GTest_FOUND)
3535
-DBUILD_SHARED_LIBS=OFF
3636
${_gtest_cmake_args}
3737
${ITLABAI_EXTERNAL_TOOLCHAIN_ARGS}
38+
${ITLABAI_EXTERNAL_WARNING_ARGS}
3839
BUILD_BYPRODUCTS
3940
${GTEST_INSTALL_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}gtest${CMAKE_STATIC_LIBRARY_SUFFIX}
4041
${GTEST_INSTALL_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}gtest_main${CMAKE_STATIC_LIBRARY_SUFFIX}

cmake/deps/kokkos.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ if(NOT Kokkos_FOUND)
3939
-DKokkos_ENABLE_EXAMPLES=OFF
4040
-DBUILD_SHARED_LIBS=OFF
4141
${ITLABAI_EXTERNAL_TOOLCHAIN_ARGS}
42+
${ITLABAI_EXTERNAL_WARNING_ARGS}
4243
BUILD_BYPRODUCTS
4344
${KOKKOS_INSTALL_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}kokkoscore${CMAKE_STATIC_LIBRARY_SUFFIX}
4445
${KOKKOS_INSTALL_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}kokkoscontainers${CMAKE_STATIC_LIBRARY_SUFFIX}

cmake/deps/onednn.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ if(NOT dnnl_FOUND)
3535
-DDNNL_LIBRARY_TYPE=SHARED
3636
-DBUILD_SHARED_LIBS=ON
3737
${ITLABAI_EXTERNAL_TOOLCHAIN_ARGS}
38+
${ITLABAI_EXTERNAL_WARNING_ARGS}
3839
BUILD_BYPRODUCTS
3940
${ONEDNN_INSTALL_DIR}/lib/dnnl.lib
4041
${ONEDNN_INSTALL_DIR}/bin/dnnl.dll

cmake/deps/opencv.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ if(NOT OpenCV_FOUND)
118118
-DPROTOBUF_UPDATE_FILES=OFF
119119
${OPENCV_FEATURE_ARGS}
120120
${ITLABAI_EXTERNAL_TOOLCHAIN_ARGS}
121+
${ITLABAI_EXTERNAL_WARNING_ARGS}
121122
CMAKE_CACHE_ARGS
122123
-DBUILD_LIST:STRING=${OPENCV_COMPONENTS_ESC}
123124
BUILD_BYPRODUCTS

cmake/deps/tbb.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ if(NOT TBB_FOUND)
1111
if(NOT _tbb_build_type)
1212
set(_tbb_build_type "Release")
1313
endif()
14-
set(_tbb_cmake_args ${ITLABAI_EXTERNAL_TOOLCHAIN_ARGS})
14+
set(_tbb_cmake_args ${ITLABAI_EXTERNAL_TOOLCHAIN_ARGS} ${ITLABAI_EXTERNAL_WARNING_ARGS})
1515

1616
if(WIN32)
1717
set(_tbb_debug_suffix "")

0 commit comments

Comments
 (0)